[Zope-dev] DateTime, Australian and US Timezones

Andreas Jung lists at zopyx.com
Tue Dec 18 00:14:26 EST 2007



--On 18. Dezember 2007 15:46:06 +1100 James Purser 
<james at jamespurser.com.au> wrote:

>
> On Tue, 2007-12-18 at 05:32 +0100, Andreas Jung wrote:
>
>> Sorry but this patch is poor (the "if False" clause makes no sense) and
>> it does not have tests.
>>
>> -aj
>
> No worries, I'm new to Python in general so I'm going to accept any
> corrections. However I believe that that is the section that is causing
> the issues, and if Falsing it hasn't produced any noticable bugs,
> problems with the system.
>
> I am more than willing to look at creating a patch that conforms if
> people indicate that the general approach (removing the assignment) is
> acceptable.

It needs a unittest in the first place. Untested code or untested patches 
are not acceptable for people applying patches if one can not determine 
what problem a particular patch is solving.

-aj
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 186 bytes
Desc: not available
Url : http://mail.zope.org/pipermail/zope-dev/attachments/20071218/2c798b2d/attachment.bin


More information about the Zope-Dev mailing list