[Zope-dev] Re: Deprecation Warning

[Tres Seaver]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Lennart Regebro wrote:
> On Wed, Jul 23, 2008 at 20:26, vyshakh krishnan
> <vyshakh.krishnan at gmail.com> wrote:
>> Hello everyone,
>>
>> Since the deprecation warning is due to the conversion of error_type
>> into string by 'raise_standardErrorMessage' method, is it still
>> necessary to use new user defined Exception class or do we want to
>> modify the function
>> 'raise_standardErrorMessage' .
> 
> We want to NOT raise a string. But an Exception object. That's pretty
> much it. As earlier: please share your worries about this. It sounds
> like a rather trivial code change, but you don't seem to think so, and
> we can help better if you explain why.

Exactly:  I made a pass through the code in November 2003 ripping out
string exceptions, but must have missed this one[1].

Please just change the 'raise_standardErrorMessage' method to avoid
converting 'error_type' to a string;  then, if anything is actually
passing 'error_type' as a string, we should fix *that* code.

[1] $ CVSROOT=""ext:cvs.zope.org:/cvs-reposotiry" \
      cvs diff -r tseaver-strexp_delenda-base \
               -r tseaver-strexp_delenda-branch


Tres.
- --
===================================================================
Tres Seaver          +1 540-429-0999          tseaver at palladion.com
Palladion Software   "Excellence by Design"    http://palladion.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFIh7GI+gerLs4ltQ4RAn4iAJ9DC8tVOBLbGhsQxtxni5gjTPLrNQCgkv6u
nh0Wr9O4Cs2CePPM5MnhJ3o=
=a32S
-----END PGP SIGNATURE-----