[Zope-dev] zope.sendmail grantma-retryfixes branch review

[Chris Withers]

Marius Gedminas wrote:
>> +        """Process results of an SMTP error
>> +           returns True to indicate break needed"""
> 
> The standard docstring convention is to do this:
> 
>            """Process results of an SMTP error.
> 
>            Returns True to indicate break needed.
>            """

This standard sucks.

             """
             Process results of an SMTP error.

             Returns True to indicate break needed.
             """

...is much more readable. If there's a tool that does something silly 
with this, fix the tool.

> Also, it's conventional to leave two blank lines between class and
> interface declarations.  (PEP-8 says this.)

What does this actually mean? I couldn't follow from your example.

Other than that, completely agree with everything you said :-)

cheers,

Chris

-- 
Simplistix - Content Management, Zope & Python Consulting
            - http://www.simplistix.co.uk