[Zope-dev] Zope3 tree not buildable with Python 2.4?

[Tres Seaver]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

In a fresh checkout of the Zope3 tree:

  $ make clean
  $ make

fails with a compile error in src/zope/app/container/_zope_app_container.c:

- ----------------------------------------------------------------------
gcc -pthread -fno-strict-aliasing -DNDEBUG -g -O3 -Wall
- -Wstrict-prototypes -fPIC -Isrc/zope/app/container -Ibuild/include-2.4
- -I/home/tseaver/projects/Zope-CVS/include/python2.4 -c
src/zope/app/container/_zope_app_container_contained.c -o
build/temp.linux-i686-2.4/src/zope/app/container/_zope_app_container_contained.o
In file included from
src/zope/app/container/_zope_app_container_contained.c:64:
src/zope/app/container/_zope_proxy_proxy.c:616: error: expected ‘=’,
‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘wrap_length’
src/zope/app/container/_zope_proxy_proxy.c:622: error: expected
declaration specifiers or ‘...’ before ‘Py_ssize_t’
src/zope/app/container/_zope_proxy_proxy.c:622: error: expected
declaration specifiers or ‘...’ before ‘Py_ssize_t’
...
- ----------------------------------------------------------------------

It appears to be a bug in the way the Python 2.5 compatibility was
added:  if I revert _zope_proxy_proxy.c to the prior revision, it then
builds with python2.4, and the tests run (but blow up later):

- ------------------------------------------------------------------------
$ cd src/zope/app/container/
$ svn merge -c -88350 _zope_proxy_proxy.c
U    _zope_proxy_proxy.c
$ cd -
$ make test_inplace ftest_inplace
...
Running zope.app.http.testing.AppHttpLayer tests:
  Tear down zope.app.generations.testing.GenerationsLayer
Traceback (most recent call last):
  File "test.py", line 61, in ?
    result = testrunner.run(defaults)
  File
"/home/tseaver/projects/Zope-CVS/Zope3-trunk/src/zope/testing/testrunner/__init__.py",
line 33, in run
    runner.run()
  File
"/home/tseaver/projects/Zope-CVS/Zope3-trunk/src/zope/testing/testrunner/runner.py",
line 134, in run
    self.run_tests()
  File
"/home/tseaver/projects/Zope-CVS/Zope3-trunk/src/zope/testing/testrunner/runner.py",
line 214, in run_tests
    setup_layers, self.failures, self.errors)
  File
"/home/tseaver/projects/Zope-CVS/Zope3-trunk/src/zope/testing/testrunner/runner.py",
line 354, in run_layer
    tear_down_unneeded(options, needed, setup_layers)
  File
"/home/tseaver/projects/Zope-CVS/Zope3-trunk/src/zope/testing/testrunner/runner.py",
line 510, in tear_down_unneeded
    l.tearDown()
  File
"/home/tseaver/projects/Zope-CVS/Zope3-trunk/src/zope/app/testing/functional.py",
line 340, in tearDown
    self.setup.tearDownCompletely()
  File
"/home/tseaver/projects/Zope-CVS/Zope3-trunk/src/zope/app/testing/functional.py",
line 300, in tearDownCompletely
    assert self.dbstack == []
AssertionError
make: *** [test_inplace] Error 1
- -------------------------------------------------------------------------


Where is this supposed to be tested?  If the tree is no longer supposed
to be buildable, then let's change the docs and setup.py to point that out.

Tres.
- --
===================================================================
Tres Seaver          +1 540-429-0999          tseaver at palladion.com
Palladion Software   "Excellence by Design"    http://palladion.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFI9JjV+gerLs4ltQ4RArBsAKCTVtPrpk7MZPbGQRSOd5Tq9+X0CQCeNxY4
WfEMKccymSaHa2BM+T3T68Y=
=bEHb
-----END PGP SIGNATURE-----