[Zope-dev] Zope Tests: 2 OK, 3 Failed

[Tres Seaver]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Zope Tests Summarizer wrote:
> Summary of messages to the zope-tests list.
> Period Mon Sep 22 11:00:00 2008 UTC to Tue Sep 23 11:00:00 2008 UTC.
> There were 5 messages: 5 from Zope Tests.
> 
> 
> Test failures
> -------------
> 
> Subject: FAILED (failures=1) : Zope-2.10 Python-2.4.4 : Linux
> From: Zope Tests
> Date: Mon Sep 22 20:54:42 EDT 2008
> URL: http://mail.zope.org/pipermail/zope-tests/2008-September/010207.html
> 
> Subject: FAILED (failures=1) : Zope-2.11 Python-2.4.4 : Linux
> From: Zope Tests
> Date: Mon Sep 22 20:56:13 EDT 2008
> URL: http://mail.zope.org/pipermail/zope-tests/2008-September/010208.html
> 
> Subject: FAILED (failures=1) : Zope-trunk Python-2.4.4 : Linux
> From: Zope Tests
> Date: Mon Sep 22 20:57:48 EDT 2008
> URL: http://mail.zope.org/pipermail/zope-tests/2008-September/010209.html

These test failures are all in tests of the 'handle_error' method of a
ClockServer instance, which does nothing more than log an error.  It
appears that these tests began to fail as a result of Rob's change to
avoid pushing the software home in at the head of sys.path:

- ------------------ %< ---------------------
- --- Zope/branches/2.10/test.py	2008-09-11 21:10:37 UTC (rev 91069)
+++ Zope/branches/2.10/test.py	2008-09-11 23:27:37 UTC (rev 91070)
@@ -53,7 +53,11 @@
         zhome = scriptdir
     shome = os.path.join(zhome, 'lib', 'python')

- -sys.path.insert(0, shome)
+# add SOFTWARE_HOME to sys.path, but only if Zope isn't already available
+try:
+    import Zope2
+except ImportError:
+    sys.path.insert(0, shome)

 defaults = '--tests-pattern ^tests$ -v'.split()
 defaults += ['-m',
- ------------------ %< ---------------------

This test fails in a straight Zope2 checkout, for the 2.10 branch, the
2.11 branch, and the trunk.  We need to keep the tests passing, whether
by fixing a bad test or reverting a change which broke them.  Rob *did*
ask for feedback on the change, and got none:

 http://permalink.gmane.org/gmane.comp.web.zope.devel/17170

I think the intent there is fine, as long as we repair the test breakage.

Note that I'm not defending the test which broke:  I don't think the
assertion error is *desired* behavior.  It looks to me as though the
test needs to force an exception of some kind, and then verify that the
traceback is logged correctly.


Tres.
- --
===================================================================
Tres Seaver          +1 540-429-0999          tseaver at palladion.com
Palladion Software   "Excellence by Design"    http://palladion.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFI2OSQ+gerLs4ltQ4RAgYqAJ428qIj376k5FHrax4oh2Eqpv0iSQCgqWYi
pBBGw8Llab9ZpnV3U1d3NMM=
=pfRG
-----END PGP SIGNATURE-----