[Zope-dev] [Checkins] SVN: zope.annotation/trunk/setup.py Whitespace fixes

Michael Howitz mh at gocept.com
Thu Apr 2 03:23:47 EDT 2009


Am 01.04.2009 um 23:44 schrieb Jacob Holm:

> Hi Baiju
>
> If this whitespace fix is based on the current style guide, I think  
> the
> guide needs to be fixed. I find the fixed version much less  
> readable. A
> function that takes this many arguments should have an exception to  
> the
> PEP 8 rule of no whitespace around the equals sign used for keyword
> arguments. I *think* a reasonable rule is that if you split the call
> over multiple lines with one argument per line, you should add single
> spaces before and after the equals sign. What does anyone else think?

What about defining the version number in front of the setup call as a  
variable and using it in the call like:

version = '3.5.0dev'

setup(
     name='zope.annotation',
     version=version,
     ...
)

This way no exception from the rule is necessary.

Yours sincerely,
-- 
Michael Howitz · mh at gocept.com · software developer
gocept gmbh & co. kg · forsterstraße 29 · 06112 halle (saale) · germany
http://gocept.com · tel +49 345 1229889 8 · fax +49 345 1229889 1
Zope and Plone consulting and development



More information about the Zope-Dev mailing list