[Zope-dev] zope.index 3.5.2 broken

[Chris McDonough]

On 8/2/09 3:07 PM, Andreas Jung wrote:
> On 02.08.09 21:00, Andreas Jung wrote:
>> On 02.08.09 20:48, Andreas Jung wrote:
>>
>>> Hi,
>>>
>>> the doctests for zope.index 3.5.2 - as used in Zope 2.12  - fail badly:
>>>
>>> File
>>> "/home/ajung/.buildout/eggs/zope.index-3.5.2-py2.6-linux-x86_64.egg/zope/index/text/tests/../textindex.txt",
>>> line 143, in textindex.txt
>>> Failed example:
>>>      [(k, "%.4f" % v) for (k, v) in index2.apply("Zorro").items()] == result
>>> Expected:
>>>      True
>>> Got:
>>>      False
>>>
>>>
>>>
>> Obviously another Python 2.5/.6 incompatiblity. zope.index 3.5.1 works fine
>> with Python 2.4-2.6 - obviously changes to okascore.c introduced with
>> zope.index
>> 3.5.2 are to blame?!
>
> The diff between 3.5.1 and 3.5.2 is pretty long and substantial. I doubt
> that such a major change us ok as a bugfix release. I should have become
> a new major release. I suggest that the current trunk should be released
> as 3.6.0 and the current 3.5.1 released should be copied to tags/3.5.3 and
> re-released.

I think your test failure is related to a 64-bit issue.  Shane has some fixes on 
the trunk that may solve this.

That said, why does Zope 2.1.2 use the zope.index textindex?  The Zope 2 
implementation is still very superior.

Before we started fixing it, there were places that the zope.index text index 
didn't actually work at all  Where it did work, it worked very, very slowly. 
We've been trying to improve it incrementally (mostly by backporting all the 
fixes that have accreted to the Zope 2 implementation).

I'll try to pin this down and make a 3.6.0 release, but Zope 2 shouldn't be 
using this index.

- C