[Zope-dev] [dev] five.localsitemanager: dependencies

[Tres Seaver]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Charlie Clark wrote:
> Am 12.02.2009 um 14:45 schrieb yuppie:
> 
>>       install_requires=[
>>         'setuptools',
>>         'Zope2 >= 2.12.dev',
>>       ],
>>
>> Is that the right way to resolve that issue? Could it cause any  
>> trouble
>> if I would check in that change?
> 
> 
> Only for someone wishing to use it totally outside of a Zope context.

Given that package's job in life, I strongly doubt that we need to worry
about anybody using it outside of a Zope2 app.  In fact, I think it
might be a good idea just to fold the package back into Zope2 (I don't
recall why it ever shipped separately).

> I'm not that familiar with Buildout but I would have thought that any  
> direct import dependencies should be listed - and zope.location  
> doesn't seem to be (neither are zope.event or zope.site for that  
> matter). OTOH the condition >= seems to be being incorrectly  
> interpreted. If this is a bug then it should be filed.

The transitive dependencies of another dependency don't need to be
listed:  the problem Yuppie was fixing was a set of over-specific
dependencies, now redundant in the new, egg-centric world of Zope 2.12.
I think another fix would be to move the Zope2 import to the top of the
list, so that its own, more specific dependencies would be installed
first:  however, I don't see much win over Yuppie's fix.


Tres.
- --
===================================================================
Tres Seaver          +1 540-429-0999          tseaver at palladion.com
Palladion Software   "Excellence by Design"    http://palladion.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFJlxyD+gerLs4ltQ4RAnMhAKCVNpXav5TpO17EQDJKPeIE/JLC1wCfVzWY
maFcuCWJJY09WMDwxsYz4G4=
=wJCe
-----END PGP SIGNATURE-----