[Zope-dev] SVN: Products.GenericSetup/trunk/Products/GenericSetup/tests/common.py Hhm, pdb?!?

[Tres Seaver]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hanno Schlichting wrote:
> Tres Seaver wrote:
>> Hanno Schlichting wrote:
>>> Log message for revision 94810:
>>>   Hhm, pdb?!?
>>> Changed:
>>>   U   Products.GenericSetup/trunk/Products/GenericSetup/tests/common.py
>>> -=-
>>> Modified: Products.GenericSetup/trunk/Products/GenericSetup/tests/common.py
>>> ===================================================================
>>> --- Products.GenericSetup/trunk/Products/GenericSetup/tests/common.py	2009-01-17 20:01:44 UTC (rev 94809)
>>> +++ Products.GenericSetup/trunk/Products/GenericSetup/tests/common.py	2009-01-17 20:41:54 UTC (rev 94810)
>>> @@ -53,7 +53,6 @@
>>>                          for i in range( len( zipped ) )
>>>                          if zipped[i][0] != zipped[i][1]
>>>                      ]
>>> -                import pdb; pdb.set_trace()
>>>              print 'Found:'
>>>              print fxml
>> That breakpoint was inside an if block guarded by 'if debug:', which
>> shouldn't be set by any "real" test.
> 
> I can put it back if you want to. I'm just accustomed to a strict
> "no-pdb"-policy in checked in code. Quite some repositories even enforce
> it via a post-commit hook.

You don't have to put it back, but you should likely delete the whole
;if debug:' block it was in while you are at it, as well as the 'debug'
argument.  All that stuff was there to dump useful output for the human
just before hitting the breakbpoint.


Tres.
- --
===================================================================
Tres Seaver          +1 540-429-0999          tseaver at palladion.com
Palladion Software   "Excellence by Design"    http://palladion.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFJc2HM+gerLs4ltQ4RAp8PAKDW3SDlxgui67bP5dcQW+K85NrrEACfbrg0
yp1zQD9fASiR+fQCOo6TsT4=
=6VqN
-----END PGP SIGNATURE-----