[Zope-dev] zope.testing 3.8 fails in mysterious ways

[Martin Aspeli]

Tres Seaver wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Martin Aspeli wrote:
>> Hi,
>>
>> I'm running the plone.z3cform tests in a Zope 2.10 instance with 
>> zope.testing 3.8 installed.
>>
>> All other tests seem to work OK, but with plone.z3cform's tests, I get:
>>
>> $ ./bin/instance test -s plone.z3cform
>> Running tests at level 1
>> Running plone.z3cform.testing_zcml_layer tests:
>>    Set up plone.z3cform.testing_zcml_layer in 0.972 seconds.
>>    Running:
>> ..........................
>>    Ran 26 tests with 0 failures and 0 errors in 0.219 seconds.
>> Running zope.testing.testrunner.layer.UnitTests tests:
>>    Tear down plone.z3cform.testing_zcml_layer ... not supported
>> Exception in thread Thread-1:
>> Traceback (most recent call last):
>>    File 
>> "/opt/local/Library/Frameworks/Python.framework/Versions/2.4/lib/python2.4/threading.py", 
>> line 442, in __bootstrap
>>      self.run()
>>    File 
>> "/opt/local/Library/Frameworks/Python.framework/Versions/2.4/lib/python2.4/threading.py", 
>> line 422, in run
>>      self.__target(*self.__args, **self.__kwargs)
>>    File 
>> "/Users/optilude/.buildout/eggs/zope.testing-3.8.0-py2.4.egg/zope/testing/testrunner/runner.py", 
>> line 418, in spawn_layer_in_subprocess
>>      while nfail > 0:
>> UnboundLocalError: local variable 'nfail' referenced before assignment
>>
>> Total: 26 tests, 0 failures, 0 errors in 5.626 seconds.
>>
>> The tests are here: 
>> http://svn.zope.org/repos/main/plone.z3cform/trunk/plone/z3cform/tests.py
>>
>> Any ideas?
> 
> I would just use the version of zope.testing which shipped with Zope
> 2.10?  That would be 3.0, I think:
> 
>  $ svn propget svn:externals \
>    projects/Zope-CVS/Zope-2.10-branch/lib/python/zope | grep testing
>  testing  \
>    svn://svn.zope.org/repos/main/zope.testing/tags/3.0/src/zope/testing

Unfortunately, I've got other packages that depend on a newer 
zope.testing (specifically, collective.testcaselayer). But I thought 
zope.testing aimed to be able to run any "valid" tests, so it sounds 
like a bug in zope.testing regardless, at least since every other test 
I've run in the same instance work fine.

Martin

-- 
Author of `Professional Plone Development`, a book for developers who
want to work with Plone. See http://martinaspeli.net/plone-book