[Zope-dev] SVN: zope.index/trunk/ - Port okascore.c optimization used in okapiiindex from Zope2 catalog

[Christian Theune]

On Tue, 2009-06-09 at 20:07 -0400, Tres Seaver wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Chris McDonough wrote:
> > Log message for revision 100775:
> >   - Port okascore.c optimization used in okapiiindex from Zope2 catalog
> >     implementation.  This module is compiled conditionally, based on
> >     whether your environment has a working C compiler.
> >   
> >   - Don't use ``len(self._docweight)`` in okapiindex _search_wids method
> >     (obtaining the length of a BTree is very expensive at scale).
> >     Instead use self.documentCount().  Also a Zope2 port.
> 
> Crap!  this set of performance fixes was added *six years ago* to the
> Zope2 version from which zope.index was forked!
> 
> Hasn't anybody been using this package?

We're using this package. The text index I can only remember in a
not-so-critical piece where performance currently is not an issue. Also,
following checkins even today wouldn't have me remember that this code
is shared.

Christian

-- 
Christian Theune · ct at gocept.com
gocept gmbh & co. kg · forsterstraße 29 · 06112 halle (saale) · germany
http://gocept.com · tel +49 345 1229889 7 · fax +49 345 1229889 1
Zope and Plone consulting and development
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part
Url : http://mail.zope.org/pipermail/zope-dev/attachments/20090610/b447af8a/attachment.bin