[Zope-dev] [PATCH] Better error support in subunit output formatter

[Tres Seaver]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Jonathan Lange wrote:
> Hello,
> 
> The subunit output formatter that was added recently currently raises
> NotImplementedError when it's given a generic "error". The error()
> method on formatters is used to communicate user error (e.g. when the
> user selects incompatible options), internal framework errors (afaict,
> only when there's a subprocess read error) and layer setUp errors.
> 
> I find the idea of masking layer setUp errors to be unconscionably
> awful, so I've attached the following patch, which changes the subunit
> formatter's error() method to print out whatever it gets. It doesn't
> have any tests, but it's simple enough, and none of the other
> formatters have tests for this method either.
> 
> Ideally, I think there should be a new method on OutputFormatter to
> handle layer setup failure. Probably teardown failure too. If someone
> wants to push back on this simple patch in favour of a new method, I
> could probably be persuaded to do the work, provided I had clear
> backwards compatibility guidelines.

Your patches look pretty reasonable to me:  can you kick them into
Launchpad so they don't get lost in the mailing list archives?  There is
a project page for zope.app.testing, but it doesn't (as of today) have
the bug tracker turned on.

 https://launchpad.net/zope.app.testing

For now, the Zope3 tracker is the right place for zope.app.* issues:

 https://bugs.launchpad.net/zope3



Tres.
- --
===================================================================
Tres Seaver          +1 540-429-0999          tseaver at palladion.com
Palladion Software   "Excellence by Design"    http://palladion.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkvAwH0ACgkQ+gerLs4ltQ57tACeP9VzumWF++MBaD6P6SohME9w
e6MAn2MYPBF3LK5TfFKRjJkNGAQfjH+w
=nYkx
-----END PGP SIGNATURE-----