[Zope-dev] Zope Tests: 31 OK, 19 Failed, 2 Unknown

[Hanno Schlichting]

On Fri, Sep 10, 2010 at 10:52 PM, Tres Seaver <tseaver at palladion.com> wrote:
> My attempts at diagnosis.
>
>> Subject: FAILED : Zope Buildbot / zope2 slave-ubuntu64
>> From: jdriessen at thehealthagency.com
>> Date: Thu Sep  9 09:31:14 EDT 2010
>> URL: http://mail.zope.org/pipermail/zope-tests/2010-September/019683.html
>
> This failure is in the tests for tempstorage.TempStorage, which likely
> hasn't kept up with recent ZODB 3.10 API changes::
>
> - ------------------------------ %< --------------------------------
> Error in test check_checkCurrentSerialInTransaction
> (tempstorage.tests.testTemporaryStorage.ZODBProtocolTests)
> Traceback (most recent call last):
>  File "/usr/lib/python2.6/unittest.py", line 279, in run
>    testMethod()
>  File
> "/home/zope/.buildout/eggs/ZODB3-3.10.0b6-py2.6-linux-x86_64.egg/ZODB/tests/BasicStorage.py",
> line 235, in check_checkCurrentSerialInTransaction
>    self._storage.tpc_finish(t)
>  File
> "/home/zope/.buildout/eggs/ZODB3-3.10.0b6-py2.6-linux-x86_64.egg/ZODB/BaseStorage.py",
> line 295, in tpc_finish
>    self._finish(self._tid, u, d, e)
>  File
> "/home/zope/.buildout/eggs/tempstorage-2.11.3-py2.6.egg/tempstorage/TemporaryStorage.py",
> line 256, in _finish
>    referencesf(data, referencesl)
>  File
> "/home/zope/.buildout/eggs/ZODB3-3.10.0b6-py2.6-linux-x86_64.egg/ZODB/serialize.py",
> line 629, in referencesf
>    u.noload()
> UnpicklingError: invalid load key, 'x'.
> - ------------------------------ %< --------------------------------
>
> I'm CC'ing the ZODB list in hopes somebody there can tell us what we
> need to do to get TemporaryStorage to conform to ZODB's expectations.

It took me a while to figure this one out. It's not actually an API
change but a side-effect of the tempstorage tests reusing some ZODB
tests.

I fixed it in https://mail.zope.org/pipermail/zodb-checkins/2010-September/012464.html

tempstorage always loads the data in _finish and thus tripped over the
invalid payload of a simple 'x' string in those tests. The normal ZODB
tests don't care about the data payload and thus were happy to ignore
the invalid data.

With current ZODB trunk I don't get any test failures anymore inside
Zope2. So once 3.10.0b7 is out, we can upgrade to it.

Hanno