[Zope-dev] SVN: Zope/branches/2.13/src/ micro optimizations

[Tres Seaver]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 07/29/2011 10:36 PM, Nikolay Kim wrote:
> Log message for revision 122429: micro optimizations

Assuming we have really good test coverage for the affected modules, the
micro-optimizations mostly look fine.  However, the following diff
changes semantics, and not just performance::

> --- Zope/branches/2.13/src/ZPublisher/HTTPRequest.py	2011-07-29
> 19:11:59 UTC (rev 122428) +++
> Zope/branches/2.13/src/ZPublisher/HTTPRequest.py	2011-07-30 02:36:10
> UTC (rev 122429) @@ -1296,7 +1290,7 @@ if n: n = n - 1 if len(path) <
> n: -                        raise KeyError, key +
> return default
> 
> v = self._script + path[:n] else:

If such a chenge is deemed to be backward compatible (I can't figure it
out from here) then it needs both a new test (or updates to the test
which asserted the old behavior) and a note in CHANGES.txt.


Tres.
- -- 
===================================================================
Tres Seaver          +1 540-429-0999          tseaver at palladion.com
Palladion Software   "Excellence by Design"    http://palladion.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk423MAACgkQ+gerLs4ltQ63aQCeOO9RRa8qJrScQFj7EkxfawP2
jd8An1C8FOW9K7MWUBsBVMcmup1C6n/c
=ppJj
-----END PGP SIGNATURE-----