[Zope-dev] zope-tests - FAILED: 13, OK: 40

[Arfrever Frehtes Taifersar Arahesis]

2011-10-31 17:02:52 Tres Seaver napisał(a):
> Hmm, there is code in the test which tries to ensure that the locale
> for the 'svn' process is set to 'C'::
> 
>  $ export ZSVN=svn+ssh://svn.zope.org/repos/main
>  $ svn log -r85956 $ZSVN/zope.app.applicationcontrol/trunk
>  r85956 | lgs | 2008-05-01 03:37:07 -0400 (Thu, 01 May 2008) | 1 line
> 
>  Add a test and a fix for bug 177733, that was causing ZopeVersion to
>  report an unknown version when running on a machine with a locale
>  different than english
>  $ svn diff -c 85956 $ZSVN/zope.app.applicationcontrol/trunk
>  ...(elide add of now-failing test)
>  --- src/zope/app/applicationcontrol/zopeversion.py...85955)
>  +++ src/zope/app/applicationcontrol/zopeversion.py...85956)
>  @@ -63,7 +63,7 @@
>       def _getSVNInfoOutput(self):
>           try:
>               proc = subprocess.Popen('svn info "%s"' % self.path,
>  -                shell=True, stdout=subprocess.PIPE)
>  +                shell=True, stdout=subprocess.PIPE, env={'LANG': 'C'})
>           except OSError:
>               pass
>           else:
> 
> I guess it is not clever enough.  Nevertheless, that test was not
> failing on any buildslave before yesterday's report.

Variables are checked in the following order: LC_ALL, LC_MESSAGES, LANG.
I suggest to override LC_ALL in test suite.

-- 
Arfrever Frehtes Taifersar Arahesis
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://mail.zope.org/pipermail/zope-dev/attachments/20111101/405929b2/attachment.bin