[Zope-dev] Merge proposal: tseaver-better_unittests branch of zope.interface

[Tres Seaver]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 03/27/2012 06:32 PM, Marius Gedminas wrote:

> I've a comment about this change, which was part of that large "merge
>  from launchpad" commit:
> 
> --- 
> zope.interface/branches/tseaver-better_unittests/src/zope/interface/_zope_interface_coptimizations.c
>
>
>
> 
(revision 118418) +++
> zope.interface/branches/tseaver-better_unittests/src/zope/interface/_zope_interface_coptimizations.c
>
>
>
> 
(revision 124742) @@ -980,5 +980,11 @@ } else -    Py_INCREF(result);
> +    { +      if (result == Py_None && default_ != NULL) +        { + 
> result = default_; +        } +      Py_INCREF(result); +    }
> 
> return result;
> 
> It seems to be a bugfix for http://pad.lv/910987 from [1]
> 
> [1] 
> http://bazaar.launchpad.net/~tseaver/zope.interface/better_unittests/revision/182
>
>
>
>
> 
I failed to find any mention of this CHANGES.txt on that branch.

Thanks for the catch.  This was indeed a fix for a problem I uncovered
while ensuring that the Python and C implementations passed the same test
suite.  I have update the 'CHANGES.txt` file on the branch to indicate
the fix.



Tres.
- -- 
===================================================================
Tres Seaver          +1 540-429-0999          tseaver at palladion.com
Palladion Software   "Excellence by Design"    http://palladion.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk9yeBcACgkQ+gerLs4ltQ6cRQCeI9K1J040qOWRI3OnB6Vu4t3M
DgEAoLSnM4RBc3tcRivZFyWbbVARUpKg
=9SeP
-----END PGP SIGNATURE-----