[Zope-dev] zope-tests - FAILED: 1, OK: 40

[Tres Seaver]

On 05/26/2012 10:45 AM, Gediminas Paulauskas wrote:
> 2012/5/26 Marius Gedminas <marius at gedmin.as>:
>> On Fri, May 25, 2012 at 10:58:20PM -0400, Tres Seaver wrote:
>>> On 05/25/2012 09:00 PM, Zope tests summarizer wrote:
>>>> [1]    FAILED  Zope 3.4 KGS / Python2.4.6 64bit linux 
>>>> https://mail.zope.org/pipermail/zope-tests/2012-May/063520.html
>>> 
>>> Ugh, the old eccentric FTP HELP failure
>>> 
>>>> 
>>>> 
>>>> Failure in test testHELP
>>>> (zope.server.ftp.tests.test_ftpserver.Tests) Traceback (most
>>>> recent call last): File 
>>>> "/usr/local/python2.4.6/lib/python2.4/unittest.py", line 260, in
>>>> run testMethod() File 
>>>> "/home/ccomb/buildout-eggs/zope.server-3.4.3-py2.4.egg/zope/server/ftp/tests/test_ftpserver.py",
>>>>
>>>> 
line 280, in testHELP self.assertEqual(self.execute('HELP', 1),
>>>> result) File "/usr/local/python2.4.6/lib/python2.4/unittest.py",
>>>> line 333, in failUnlessEqual raise self.failureException, \
>>>> AssertionError: '214-The following commands are recognized\r\n'
>>>> != '214-The following commands are recognized\r\nHelp goes here
>>>> somewhen.\r\n214 Help done.\r\n'
>>> 
>>> 
>>> I have no idea why this would be failing *now*, as opposed to
>>> yesterday.
>> 
>> It's nondeterministic.
>> 
>> I once posted a proposed patch: 
>> https://mail.zope.org/pipermail/zope-dev/2010-December/042138.html
>> 
>> I didn't commit it since I was completely unable to reproduce the 
>> failure on my machine, and so couldn't verify that it was the
>> correct fix.
> 
> I have committed this fix a year ago:
> 
> http://zope3.pov.lt/trac/changeset/121089/zope.server/trunk
> 
> and also merged to 3.6 branch. But there is no branch for Zope 3.4.

Thanks for the heads up:  I went looking for how the KGS worked, and
found (I believe) that the KGS was managed via the 'zope.release'
package:  it's buildout doesnt have a "devlopment checkouts" model
similar to the ZTK:  it only tests released packages.  I don't think it
is worthwhile to backport your fix to a new 3.4.4 release of zope.server;
 instead, I recommend that we running the KGS tests at all (acknowledging
that nobody is doing active development on it).


Tres.
-- 
===================================================================
Tres Seaver          +1 540-429-0999          tseaver at palladion.com
Palladion Software   "Excellence by Design"    http://palladion.com