[Zope-PAS] Re: [RFC] Extending CookieAuthHelper

[Tres Seaver]

Jens Vagelpohl wrote:
>>>>> It seems that instead of the login method calling updateCredentials 
>>>>> on the CookieAuthHelper itself, it should inform the PAS instance 
>>>>> so that the plugins registered for updateCredentials can fire. Am I 
>>>>> overlooking something?
>>>>
>>>>
>>>>
>>>> That sounds reasonable to me. Tres and I were discussing that many 
>>>> of the plugin points need to be surfaced at the PAS level, so it can 
>>>> fire any interested parties.
>>>
>>> There are probably a myriad more or less complicated ways to make 
>>> this happen. One simple way could be to talk to the plugin registry 
>>> itself and call "listPlugins" with the desired interface to retrieve 
>>> the active plugins and call updateCredentials on each. Does that 
>>> sound like a reasonable thing to do inside a plugin (because only PAS 
>>> itself seeems to work that way now)?
>>
>>
>> I would add an 'updateCredentials' method to PAS, and have it delegate 
>> to the plugins.
> 
> 
> Last question: do you want me to add something to the public interface 
> on the PAS instance itself to return the PAS instance, or do you prefer 
> using aq_parent(aq_inner(self)) in the plugin?

I have a patch in hand which adds a '_getPAS' API to BasePlugin, and 
modifies all the standard plugins to use it.  I will check it in as soon 
as I run the tests.

Tres.
-- 
===============================================================
Tres Seaver                                tseaver at zope.com
Zope Corporation      "Zope Dealers"       http://www.zope.com