[Zope] Odp: [Zope] Re: [Zope-dev] Zope ...2.1.7 update - patch for EMarket 0.1.03

Fri, 16 Jun 2000 22:40:13 +0200

>Hi Adam,
>
>I looked at your patch...
>
>*** EMarket.py.orig Thu Jun 01 00:06:01 2000
>--- EMarket.py Fri Jun 16 02:56:35 2000
>***************
>*** 258,265 ****
>      newMainF.transactionFolder = newTransF
>
>      Products.MailHost.MailHost.add(newMainF, 'eMarketMailhost',
>!                                    smtp_host = smtp_host,
>!                                    localhost = localhost)
>
>      theMailHost = getattr(newMainF,'eMarketMailhost')  ### TODO... change documents that send mail to be proxies for Manager
>
>--- 258,264 ----
>      newMainF.transactionFolder = newTransF
>
>      Products.MailHost.MailHost.add(newMainF, 'eMarketMailhost',
>!                                    smtp_host = smtp_host)
>
>      theMailHost = getattr(newMainF,'eMarketMailhost')  ### TODO... change documents that send mail to be proxies for Manager
>
>
>Looking at the source, it's not clear what was broken by the localhost
>line in the factory..... so what was the error that prompted the patch?

Hi Steve

(Apologize for my poor english and I hope that you will understand something :)).

Its happends _only_ for Zope 2.1.7 and 2.2b1
Currently I not have a traceback but was not possible to create
instance of EMarket (and other product which creates own MailHost insance too)
mesage was (or something like): 'localhost' is not keyword parameter.

My patch is _only_ for Zope2.1.7 and for Zope2.2 where API for MailHost was changed.
For this versions method MailHost.add() have a form:

def add(self, id, title='', smtp_host=None, smtp_port=25, REQUEST=None):

but old (for Zope 2.1.6 or ealier) had a form:

def add(self, id, title='', smtp_host=None, localhost='localhost', smtp_port=25, timeout=1.0, REQUEST=None):

For new MailHost API (which based on Python standard smtplib, and it seems will be 'official' version
in the future) parameters localhost and timeout was removed.

Besause 2.1.7 was deleted and 2.1.6 stays back as last stable version, my patch not needed now
but for Zope 2.2 still will be (I think).

I think that portable solutions for EMarket its simply omitting localhost (as in my patch) because
its not needed anywhere in your excellent EMarket product.

Of course my previous patch is minimal, only  for compatibility.
I attached  more full patch with smtp_port support.
Take a look for attachements.

Best Regards

Adam

karpierz@itl.pl

begin 666 EMarket.py.patch
M*BHJ($5-87)K970N<'DN;W)G"51H=2!*=6X@,#$@,# Z,#8Z,#$@,C P, HM
M+2T@14UA<FME="YP>0E&<FD@2G5N(#$V(#(R.C$X.C Q(#(P,# **BHJ*BHJ
M*BHJ*BHJ*BHJ"BHJ*B Q-S(L,3<W("HJ*BH*+2TM(#$W,BPQ-S@@+2TM+0H@
M(" @("!D969A=6QT:&]S=" ](&=E=&AO<W1N86UE*"D*("!E>&-E<'0Z"B @
M(" @(&1E9F%U;'1H;W-T(#T@)VQO8V%L:&]S="<**R!D969A=6QT<&]R=" ]
M(#(U"B @"B @"B @861D36%R:V5T271E;7-&;VQD97)&;W)M/4A434Q&:6QE
M*"=M87)K971)=&5M<T9O;&1E<D%D9"<L(&=L;V)A;',H*2D**BHJ*BHJ*BHJ
M*BHJ*BHJ"BHJ*B Q.3@L,C V("HJ*BH*(" *(" @(" @<F5T=7)N(')E<W5L
M= H@( HA(&%D9$5-87)K971&;W)M/4A434Q&:6QE*"=E36%R:V5T061D)RP@
M9VQO8F%L<R@I+"!D969A=6QT:&]S=" ](&1E9F%U;'1H;W-T*0H@(" @(" *
M(2!D968@861D14UA<FME="AS96QF+"!I9"P@=&ET;&4])R<L('-M='!?:&]S
M=" ](&1E9F%U;'1H;W-T+"!L;V-A;&AO<W0@/2!D969A=6QT:&]S="P@<')O
M8V5S<U523#TG<')O8V5S<T]R9&5R)RP*(" @(" @(" @(" @(" @("!L;V-A
M;%-E8W)E=#TG)RP@8V]N=&%C=$EN9F\])R<L($5-87)K97154DP])R<L"B @
M(" @(" @(" @(" @(" @9&5F875L=%]H=&UL(#T@)R<L(')E<75I<F5,;V=I
M;B ](#$L(&%D9%1O0V%R=%1E>'0@/2 G061D(%1O($-A<G0G+"!215%515-4
M/4YO;F4I.@H@( HM+2T@,3DY+#(P-R M+2TM"B @"B @(" @(')E='5R;B!R
M97-U;'0*(" *(2!A9&1%36%R:V5T1F]R;3U(5$U,1FEL92@G94UA<FME=$%D
M9"<L(&=L;V)A;',H*2P@9&5F875L=&AO<W0@/2!D969A=6QT:&]S="P@(&1E
M9F%U;'1P;W)T(#T@9&5F875L='!O<G0I"B @(" @( HA(&1E9B!A9&1%36%R
M:V5T*'-E;&8L(&ED+"!T:71L93TG)RP@<VUT<%]H;W-T(#T@9&5F875L=&AO
M<W0L('-M='!?<&]R=" ](&1E9F%U;'1P;W)T+"!P<F]C97-S55),/2=P<F]C
M97-S3W)D97(G+ H@(" @(" @(" @(" @(" @(&QO8V%L4V5C<F5T/2<G+"!C
M;VYT86-T26YF;STG)RP@14UA<FME=%523#TG)RP*(" @(" @(" @(" @(" @
M("!D969A=6QT7VAT;6P@/2 G)RP@<F5Q=6ER94QO9VEN(#T@,2P@861D5&]#
M87)T5&5X=" ]("=!9&0@5&\@0V%R="<L(%)%455%4U0]3F]N92DZ"B @"BHJ
M*BHJ*BHJ*BHJ*BHJ*@HJ*BH@,C$U+#(R,2 J*BHJ"B @(" @(&YE=TUA:6Y&
M+FED(#T@:60*(" @(" @;F5W36%I;D8N=&ET;&4@/2!T:71L90H@(" @("!N
M97=-86EN1BYS;71P7VAO<W0@/2!S;71P7VAO<W0*(2 @(" @;F5W36%I;D8N
M;&]C86QH;W-T(#T@;&]C86QH;W-T"B @(" @(&YE=TUA:6Y&+G!R;V-E<W-5
M4DP@/2!P<F]C97-S55),"B @(" @(&YE=TUA:6Y&+FQO8V%L4V5C<F5T(#T@
M;&]C86Q396-R970*(" @(" @;F5W36%I;D8N8V]N=&%C=$EN9F\@/2!C;VYT
M86-T26YF;PHM+2T@,C$V+#(R,B M+2TM"B @(" @(&YE=TUA:6Y&+FED(#T@
M:60*(" @(" @;F5W36%I;D8N=&ET;&4@/2!T:71L90H@(" @("!N97=-86EN
M1BYS;71P7VAO<W0@/2!S;71P7VAO<W0*(2 @(" @;F5W36%I;D8N<VUT<%]P
M;W)T(#T@<VUT<%]P;W)T"B @(" @(&YE=TUA:6Y&+G!R;V-E<W-54DP@/2!P
M<F]C97-S55),"B @(" @(&YE=TUA:6Y&+FQO8V%L4V5C<F5T(#T@;&]C86Q3
M96-R970*(" @(" @;F5W36%I;D8N8V]N=&%C=$EN9F\@/2!C;VYT86-T26YF
M;PHJ*BHJ*BHJ*BHJ*BHJ*BH**BHJ(#(U.2PR-C4@*BHJ*@H@(" @(" *(" @
M(" @4')O9'5C=',N36%I;$AO<W0N36%I;$AO<W0N861D*&YE=TUA:6Y&+" G
M94UA<FME=$UA:6QH;W-T)RP*(" @(" @(" @(" @(" @(" @(" @(" @(" @
M(" @(" @(" @('-M='!?:&]S=" ]('-M='!?:&]S="P*(2 @(" @(" @(" @
M(" @(" @(" @(" @(" @(" @(" @(" @(&QO8V%L:&]S=" ](&QO8V%L:&]S
M="D*(" *(" @(" @=&AE36%I;$AO<W0@/2!G971A='1R*&YE=TUA:6Y&+"=E
M36%R:V5T36%I;&AO<W0G*2 @(R,C(%1/1$\N+BX@8VAA;F=E(&1O8W5M96YT
M<R!T:&%T('-E;F0@;6%I;"!T;R!B92!P<F]X:65S(&9O<B!-86YA9V5R"B @
M"BTM+2 R-C L,C8V("TM+2T*(" @(" @"B @(" @(%!R;V1U8W1S+DUA:6Q(
M;W-T+DUA:6Q(;W-T+F%D9"AN97=-86EN1BP@)V5-87)K971-86EL:&]S="<L
M"B @(" @(" @(" @(" @(" @(" @(" @(" @(" @(" @(" @("!S;71P7VAO
M<W0@/2!S;71P7VAO<W0L"B$@(" @(" @(" @(" @(" @(" @(" @(" @(" @
M(" @(" @("!S;71P7W!O<G0@/2!S;71P7W!O<G0I"B @"B @(" @('1H94UA
M:6Q(;W-T(#T@9V5T871T<BAN97=-86EN1BPG94UA<FME=$UA:6QH;W-T)RD@
M(",C(R!43T1/+BXN(&-H86YG92!D;V-U;65N=',@=&AA="!S96YD(&UA:6P@
==&\@8F4@<')O>&EE<R!F;W(@36%N86=E<@H@( H`
`
end

begin 666 eMarketAdd.dtml.patch
M*BHJ(&5-87)K971!9&0N9'1M;"YO<FEG"49R:2!-87D@,3D@,C Z-30Z,3D@
M,C P, HM+2T@94UA<FME=$%D9"YD=&UL"49R:2!*=6X@,38@,C(Z,3DZ-3D@
M,C P, HJ*BHJ*BHJ*BHJ*BHJ*BH**BHJ(#,R+#,W("HJ*BH*+2TM(#,R+#0S
M("TM+2T*(" @(" @(" @(" @/"]T9#X*(" )/"]T<CX*(" )/'1R/@HK( D@
M(#QT:"!A;&EG;CTB3$5&5"(@=F%L:6=N/2)43U B/CQE;3Y33510(%!O<G0\
M+V5M/CPO=&@^"BL@"2 @/'1D(&%L:6=N/2),1494(B!V86QI9VX](E1/4"(^
M"BL@(" @(" @(" @(" @/&EN<'5T('1Y<&4](E1%6%0B(&YA;64](G-M='!?
M<&]R=#II;G0B('9A;'5E/2(\9'1M;"UV87(@9&5F875L='!O<G0^(B!S:7IE
M/2(T(CX**R @(" @(" @(" @/"]T9#X**R )/"]T<CX**R )/'1R/@H@( D@
M(#QT:"!A;&EG;CTB3$5&5"(@=F%L:6=N/2)43U B/E)E;&%T:79E(%!A=&@@
M9G)O;2!M86EN($5-87)K970@9F]L9&5R('1O(&9R;VYT('!A9V4N/&)R/@H@
M(" @(" @(" @(" @(" @(" @(" @(" @(" @(" @(" @(" @(" @(" H9F]R
M(')E9&ER96-T('1O($5-87)K970N($EF(&EN(&1O=6)T+"!L96%V92!B;&%N
L:RD\+W1H/@H@( D@(#QT9"!A;&EG;CTB3$5&5"(@=F%L:6=N/2)43U B/@H`
`
end