[Zope] ExtFile product bug (with fix)

Emmanuel Viennet emmanuel.viennet@lipn.univ-paris13.fr
Sun, 23 Dec 2001 00:41:26 +0100


I found a bug in ExtFile product.

The handling of If-Modified-Since HTTP header was broken,
leading to severe problems when "reloading" images
(especially when running zope under Apache).


Here is the correction (vs ExtFile.py,v 1.37.2.1):

--- ExtFile.py	Sat Dec 22 23:40:40 2001
+++ ExtFile.py.orig	Tue Sep 11 02:04:10 2001
@@ -216,8 +216,8 @@
  	 
				last_mod = long(self._p_mtime)
  	 
			else:
  	 
				last_mod = long(0)
- 
				if last_mod > 0 and last_mod <= mod_since:
- 
					REQUEST.RESPONSE.setStatus(304)
+ 
				if last_mod > 0 and last_mod < mod_since:
+ 
					RESPONSE.setStatus(304)
  	 
				return ''
  		
  		if hasattr(self,'has_preview') and self.has_preview: has_preview = 1

< 	 
			if last_mod > 0 and last_mod <= mod_since:
< 	 
				REQUEST.RESPONSE.setStatus(304)
---
 > 		 
		if last_mod > 0 and last_mod < mod_since:
 > 		 
			RESPONSE.setStatus(304)

  	 
				return ''
  		
  		if hasattr(self,'has_preview') and self.has_preview: has_preview = 1