[Zope] Re: request.locale - do we have this in 2.9.4?

[Dieter Maurer]

Philipp von Weitershausen wrote at 2006-9-5 16:28 +0200:
>Maciej Wisniowski wrote:
>>  > I consider this a feature request but not as a bug.
>> Ehm... I'm not sure whether we understand each other.
>> 
>> I mean the bug
>
>There is no bug.

Seems a funny interpretation of "no bug" for me...
>
>> is that DateDisplayWidget in Zope2.9.4 uses
>> request.locale which as you said is from Zope3 world. So, as far as I
>> understand, reference to 'request.locale' shouldn't appear in Zope
>> 2.9.4 code at all but it does... Do you mean it is correct??
>
>DateDisplayWidget expects an IBrowserRequest. Zope 2's request only 
>pretends to be an IBrowserRequest.

If that is not a bug (pretending to implement "IBrowserRequest" but not
doing so) what is a bug?

>At the current state, it can't 
>implement the whole interface.

Which means, that there is a bug but you have currently little chance
to fix it...


By the way, you could introduce a configuration option
that allows the user to determine whether he is more interested
in a true "IBrowserRequest" request or a more backward compatible
request.


>That's a known issue, but we can't do anything about it, at least not in 
>DateDisplayWidget (and numerous other places where request.locale is 
>used). The problem's roots go deeper.

That you know it and do not want to change it does not mean that
"bug" is not an appropriate term...



-- 
Dieter