[Zope] oddity in MailHost queue processor thread

[Tres Seaver]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Maric Michaud wrote:
> Tres Seaver a écrit :
> 
>  >> I was surprised by the behavior of asynchronous mailing in zope 2.11.3
>  >> MailHost product. It creates a thread by instance of MailHost by the
>  >> mean of using self.absolute_url(1) as key for the queue_threads 
> dictionnary.
>  >>
>  >> It seems obviously wrong, IMO, if several instances share the same 
> queue
>  >>   directory, mesages actually get sent more than once.
>  >>
>  >> Following is the monkey patch which works fine for me, but the idea is
>  >> straightforward, it's to use the realpath of the 
> smtp_queue_directory as
>  >> the identifier of the thread, ensuring that MailHosts that share the
>  >> same queue directory will also share the same thread for processing 
> mails.
>  >
>  > It looks like a bug to me:  could you please report it to the tracker at:
>  >
>  >   http://bugs.launchpad.net/zope2
>  >
>  > Also, if you could convert your monkeypatch into a real diff against the
>  > source, that would help expedite.  The basic procedure is outlined at:
>  >
>  >   http://docs.zope.org/developer/noncommitter-svn.html
> 
> Ok, I'll do that, soon.

Thanks for posting the bug and fix to Launchpad -- I have merged it for
the next 2.11 and 2.12 releases, as well as to the trunk.


Tres.
- --
===================================================================
Tres Seaver          +1 540-429-0999          tseaver at palladion.com
Palladion Software   "Excellence by Design"    http://palladion.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkvgJEgACgkQ+gerLs4ltQ4JEgCfSRZGizktQxo6pberCM/X5PNz
1bgAoKeRw/bvooXZCQhHNxAKuM9fDUG7
=3V6A
-----END PGP SIGNATURE-----