[zope2-tracker] PCGIServer.py patch proposal

[white silence]

Even i know that the PCGI method is deprecated, IMHO it is another
richness of Zope and can be useful in some scenarios, specially now
that Plone4 is faster and less resource-consuming . Using Plone 4 i
got the error below.

Someone pointed me to this
https://bugs.launchpad.net/python/+bug/418454 , so i almost pasted the
same to the "push" method in PCGIServer.py, and it seems to work by
now.

Could some developer, please, check the patch attached and improve it
if necessary ?

Many thanks!


Error trace is :
============================================================================================
~/opt/var/zopeservers/instances/my_instance4$ ./bin/instance fg
2010-11-07 14:53:40 INFO ZServer PCGI Server started at Sun Nov  7 14:53:40 2010
	Unix socket: /home/user/opt/var/zopeservers/instances/my_instance4/var/pcgi.soc
2010-11-07 14:53:53 WARNING ZODB.blob (10771) Blob dir
/home/user/opt/var/zopeservers/instances/my_instance4/var/blobstorage/
has insecure mode setting
2010-11-07 14:54:32 INFO Zope Ready to handle requests
2010-11-07 14:54:32 ERROR ZServerPublisher exception caught
Traceback (most recent call last):
  File "/home/user/opt/var/zopeservers/packages/eggs/Zope2-2.12.10-py2.6-linux-i686.egg/ZServer/PubCore/ZServerPublisher.py",
line 33, in __init__
    b._finish()
  File "/home/user/opt/var/zopeservers/packages/eggs/Zope2-2.12.10-py2.6-linux-i686.egg/ZServer/PCGIServer.py",
line 354, in _finish
    self.stdout.close()
  File "/home/user/opt/var/zopeservers/packages/eggs/Zope2-2.12.10-py2.6-linux-i686.egg/ZServer/PCGIServer.py",
line 385, in close
    self._channel.push('%010d%s%010d' % (l, data, 0), 0)
  File "/home/user/opt/var/zopeservers/packages/eggs/Zope2-2.12.10-py2.6-linux-i686.egg/ZServer/PCGIServer.py",
line 195, in push
    self.producer_fifo.push(producer)
AttributeError: 'collections.deque' object has no attribute 'push'
^C2010-11-07 14:54:46 INFO SignalHandler Caught signal SIGINT
2010-11-07 14:54:46 INFO Z2 Shutting down
-------------- next part --------------
A non-text attachment was scrubbed...
Name: push_pcgiserver.patch
Type: text/x-patch
Size: 1172 bytes
Desc: not available
Url : http://mail.zope.org/pipermail/zope2-tracker/attachments/20101107/87826841/attachment.bin