[Zope3-checkins] CVS: Zope3/lib/python/Zope/App/OFS/Services/ErrorReportingService - ErrorReportingService.py:1.12

[Steve Alexander]

Update of /cvs-repository/Zope3/lib/python/Zope/App/OFS/Services/ErrorReportingService
In directory cvs.zope.org:/tmp/cvs-serv3072

Modified Files:
	ErrorReportingService.py 
Log Message:
Removed Christian Theune's XXX comment.

If you comment like this in the source, please post a question to
zope3-dev also, so that someone will answer the question.
It is only by chance that I saw this commit message, and thus could
easily address the answer to the correct person.

Views and Resources and other Presentation components are always concerned
with Requests.

Other things are also concerned with Requests.
The ErrorReportingService is concerned with a Request because just about
everything Zope does is initiated by a Request of some sort.
So, when you log an error, it makes sense to describe the Request that
could not be satisfied due to that error.

There are other services that are concerned with requests. For example,
the Views service.

In general, your content components will not be directly concerned with
requests. It is up to presentation components to extract pertinent
information from the request, and pass just that application-pertinent
information to the content component. So, content components aren't
concerned with requests.



=== Zope3/lib/python/Zope/App/OFS/Services/ErrorReportingService/ErrorReportingService.py 1.11 => 1.12 ===
--- Zope3/lib/python/Zope/App/OFS/Services/ErrorReportingService/ErrorReportingService.py:1.11	Sat Dec  7 12:27:29 2002
+++ Zope3/lib/python/Zope/App/OFS/Services/ErrorReportingService/ErrorReportingService.py	Tue Dec 10 04:24:58 2002
@@ -68,9 +68,6 @@
     # Exceptions that happen all the time, so we dont need
     # to log them. Eventually this should be configured
     # through-the-web.
-    #
-    # XXX If I understand that right, "request" only should
-    # be used within a view. Could someone explain why I meet that here?
     def raising(self, info, request=None):
         """Log an exception.
         Called by ZopePublication.handleException method.