[Zope3-checkins] CVS: Products3/z3checkins - TODO:1.4 container.pt:1.5 message.pt:1.4

Marius Gedminas mgedmin@codeworks.lt
Wed, 16 Apr 2003 07:46:07 -0400


Update of /cvs-repository/Products3/z3checkins
In directory cvs.zope.org:/tmp/cvs-serv14938

Modified Files:
	TODO container.pt message.pt 
Log Message:
z3checkins:
- Icons are now also shown in message view
- Refresh link now moves to the most recent batch (latest checkins)
- Updated TODO list


=== Products3/z3checkins/TODO 1.3 => 1.4 ===
--- Products3/z3checkins/TODO:1.3	Wed Apr 16 03:47:46 2003
+++ Products3/z3checkins/TODO	Wed Apr 16 07:46:06 2003
@@ -1,15 +1,17 @@
-- Remember the last-seen message in a cookie and display a <hr> there; perhaps
+I definitely want to do the following:
+
+- Highlight branch tags in message body
+- Detect URLs in checkin comments and make those into <a> elements
+- Remember the last-seen message in a cookie and display a <hr> there.  Perhaps
   keep a FIFO of, say, last 5 boundaries
 - Detect several checkins with the same checkin comment and group them in some
-  way
-- Detect URLs in checkin comments and make those into <a> elements
-- Detect when the sidebar is already installed and do not display "add to
-  sidebar"
+  way (e.g. display <em>(same checkin)</em> instead of repeating the comment)
 - Include all messages sent to zope3-checkins, not just checkin messages
-- Show the icons in message view
-- Refresh link should not just refresh, but also move to the newest batch
+
+I'm not sure I'll find time for these:
+
 - Add links to the specific versions of the files mentioned in the CVS web
   interface
 - Filtering (by branch, by author, etc)
-- Verify how this all works in other browsers beside Mozilla
+- Verify how all this works in other browsers beside Mozilla
 - Is storing all the messages in a single folder scalable enough?


=== Products3/z3checkins/container.pt 1.4 => 1.5 ===
--- Products3/z3checkins/container.pt:1.4	Wed Apr 16 07:32:58 2003
+++ Products3/z3checkins/container.pt	Wed Apr 16 07:46:06 2003
@@ -21,7 +21,8 @@
                   msg_view python: sidebar and '@@html-sidebar' or '@@html'">
 <h1>Zope 3 Checkins</h1>
 
-<div class="toolbar">
+<div class="toolbar"
+     tal:define="first_batch python:int(request.get('start', '0')) <= 0">
 <tal:block tal:condition="not: usage/sidebar" tal:replace='structure string:
 <script language="JavaScript" type="text/javascript">
 <!--
@@ -34,7 +35,10 @@
 '/>
 <a tal:attributes="target target"
    href="http://mail.zope.org/pipermail/zope3-checkins/">List archives</a>
-<a href="javascript:window.location.reload()">Refresh</a>
+<a tal:condition="first_batch"
+   href="javascript:window.location.reload()">Refresh</a>
+<a tal:condition="not: first_batch"
+   tal:attributes="href request/URL">Newest checkins</a>
 </div>
 
 <div class="navigation">


=== Products3/z3checkins/message.pt 1.3 => 1.4 ===
--- Products3/z3checkins/message.pt:1.3	Thu Apr  3 07:48:48 2003
+++ Products3/z3checkins/message.pt	Wed Apr 16 07:46:06 2003
@@ -29,9 +29,16 @@
     .signature { color: gray; }
     .trail { color: gray; }
     .tab { color: gray; }
+    img.icon { float: right; padding: 0ex; margin: 2px; border: none; }
   </style>
 </head>
 <body>
+<img class="icon"
+     tal:define="icon view/icon"
+     tal:attributes="src icon/src; alt icon/alt; title icon/title" />
+<img tal:condition="context/branch"
+     class="icon" src="++resource++branch.png" alt="Branch"
+     tal:attributes="title string:Branch: ${context/branch}"/>
 <div class="headers">
 <p><span class="header">From:</span> <span class="value" tal:content="context/author" /></p>
 <p><span class="header">Date:</span> <span class="value" tal:content="context/date/@@rfc822" /></p>