[Zope3-checkins] CVS: Zope3/src/zope/app/publication - zopepublication.py:1.8

R. David Murray bitz@bitdance.com
Sat, 25 Jan 2003 00:54:28 -0500


Update of /cvs-repository/Zope3/src/zope/app/publication
In directory cvs.zope.org:/tmp/cvs-serv21066

Modified Files:
	zopepublication.py 
Log Message:
Applied fix from Sean posted to mailing list.  As per SteveA's advice,
added XXX comment calling for unit test.  I don't know enough right
now to write the unit test; from a quick look at the tests, I suspect
there are many code paths in the handleException method that are
not tested.


=== Zope3/src/zope/app/publication/zopepublication.py 1.7 => 1.8 ===
--- Zope3/src/zope/app/publication/zopepublication.py:1.7	Thu Jan  2 10:47:22 2003
+++ Zope3/src/zope/app/publication/zopepublication.py	Sat Jan 25 00:54:25 2003
@@ -218,7 +218,8 @@
 
             # Convert ConflictErrors to Retry exceptions.
             if retry_allowed and isinstance(exc_info[1], ConflictError):
-                logger.getLogger('ZopePublication').warn(
+                #XXX this code path needs a unit test
+                logging.getLogger('ZopePublication').warn(
                     'Competing writes/reads at %s',
                     request.get('PATH_INFO', '???'),
                     exc_info=True)