[Zope3-checkins] CVS: Zope3/src/zope/fssync - fssync.py:1.34

Fred L. Drake, Jr. fred@zope.com
Wed, 2 Jul 2003 17:13:19 -0400


Update of /cvs-repository/Zope3/src/zope/fssync
In directory cvs.zope.org:/tmp/cvs-serv24403

Modified Files:
	fssync.py 
Log Message:
- add some comments
- add missing arguments


=== Zope3/src/zope/fssync/fssync.py 1.33 => 1.34 ===
--- Zope3/src/zope/fssync/fssync.py:1.33	Wed Jun 11 11:50:55 2003
+++ Zope3/src/zope/fssync/fssync.py	Wed Jul  2 17:13:14 2003
@@ -194,6 +194,8 @@
 
         XXX This doesn't support proxies or redirect responses.
         """
+        # XXX Don't change the case of the header names; httplib might
+        # not treat them in a properly case-insensitive manner.
         assert self.rooturl
         if not path.endswith("/"):
             path += "/"
@@ -234,6 +236,8 @@
         other text documents as-is; and for non-text documents,
         returns just a string giving the content-type.
         """
+        # Too often, we just get HTTP response code 200 (OK), with an
+        # HTML document that explains what went wrong.
         data = fp.read()
         ctype = headers["Content-type"]
         if ctype == "text/html":
@@ -311,7 +315,8 @@
             else:
                 names = self.metadata.getnames(target)
                 if not names:
-                    method(target) # Will raise an exception
+                    # just raise Error directly?
+                    method(target, *more) # Will raise an exception
                 else:
                     for name in names:
                         method(join(target, name), *more)