[Zope3-checkins] CVS: Zope3/src/zope/app/utilities -
schema.py:1.7.2.1
Jim Fulton
jim at zope.com
Mon Sep 29 11:19:59 EDT 2003
Update of /cvs-repository/Zope3/src/zope/app/utilities
In directory cvs.zope.org:/tmp/cvs-serv16509
Modified Files:
Tag: schema_utility_persistence
schema.py
Log Message:
This implementation violates a private variable of interfaces. We need
to take a step back and think about the mutability of interfaces.
There is code that counts on interfaces being immutable, in large
part, for caching purposes. Persistent interfaces already violate
this assumption.
=== Zope3/src/zope/app/utilities/schema.py 1.7 => 1.7.2.1 ===
--- Zope3/src/zope/app/utilities/schema.py:1.7 Wed Sep 24 17:18:35 2003
+++ Zope3/src/zope/app/utilities/schema.py Mon Sep 29 11:19:58 2003
@@ -38,6 +38,11 @@
def __init__(self):
super(SchemaUtility, self).__init__('', (PersistentInterface,))
self.schemaPermissions = PersistentDict()
+
+
+ # XXX This is bogus. We are violating a private variable.
+ # We need to think harder about how we do this.
+ # The same applies to other similar cases below.
self._InterfaceClass__attrs = PersistentDict()
def setName(self, name):
More information about the Zope3-Checkins
mailing list