[Zope3-checkins] Re: CVS: ZODB/src/ThreadedAsync - __init__.py:1.8

[Philipp von Weitershausen]

Tres Seaver wrote:
> Martijn Faassen wrote:
> 
>> Philipp von Weitershausen wrote:
>>
>>> 'loop' needed by the Zope3 startup process. Please do not only rely 
>>> on passing unit tests before checking in. Quickly starting up Z3 
>>> would have shown you this error :).
>>
>> Heh, this was in a test run where I tested my changes against Zope 2, 
>> Zope 3 and ZODB, I just didn't *start* Zope 3 this time, and there we 
>> go. Silly me. :)
> 
> This kind of hidden dependency should probably either get a comment (put 
> the 'loop' import on its own line, e.g.), or else we should find a way 
> to write a test which exposes the need for it.

Well, this was in an __init__.py file which does nothing but import 
stuff. It should be pretty obvious that this is only to ease imports for 
other packages.

Comment all you want. I think we'll just have to be more careful when 
removing unused imports. :)

Philipp