[Zope3-checkins] CVS: ZODB/src/ZODB/FileStorage - FileStorage.py:1.8

Tim Peters tim.one at comcast.net
Tue Mar 16 15:46:21 EST 2004


Update of /cvs-repository/ZODB/src/ZODB/FileStorage
In directory cvs.zope.org:/tmp/cvs-serv30730/src/zodb/filestorage

Modified Files:
	FileStorage.py 
Log Message:
XXX comments about the confusing self._packt (it appears in reality to be
a two-state flag, with possible values z64 or None -- eh?).


=== ZODB/src/ZODB/FileStorage/FileStorage.py 1.7 => 1.8 ===
--- ZODB/src/ZODB/FileStorage/FileStorage.py:1.7	Thu Feb 26 19:31:55 2004
+++ ZODB/src/ZODB/FileStorage/FileStorage.py	Tue Mar 16 15:46:19 2004
@@ -107,6 +107,8 @@
                   FileStorageFormatter):
 
     # default pack time is 0
+    # XXX It's unclear what this is for.  Looks like the only values it
+    # XXX can ever have are z64 and None.
     _packt = z64
 
     _records_before_save = 10000
@@ -1128,6 +1130,8 @@
                 return pos
             if stop_at_pack:
                 # check the status field of the transaction header
+                # XXX Looks like self._packt is either z64 or None, so unclear
+                # XXX what the _tid < self._packt is trying to say.
                 if h[16] == 'p' or _tid < self._packt:
                     break
         raise UndoError("Invalid transaction id")




More information about the Zope3-Checkins mailing list