[Zope3-checkins] SVN: Zope3/trunk/src/zope/ rework many XXXs
Benji York
benji at zope.com
Fri Jul 29 14:19:31 EDT 2005
Log message for revision 37557:
rework many XXXs
Note the Zope 3 XXX dogma: XXX are only to be used for critical bugs that must
be fixed before the next release. They are not for:
* questions (use ???)
* to mark details that the reader should be weary of (use no marker, that's
what comments are for)
* noting things that should be done in the future (use TODO).
Changed:
U Zope3/trunk/src/zope/app/component/browser/configure.zcml
U Zope3/trunk/src/zope/app/component/configure.zcml
U Zope3/trunk/src/zope/app/component/registration.py
U Zope3/trunk/src/zope/app/container/_zope_app_container_contained.c
U Zope3/trunk/src/zope/app/container/_zope_proxy_proxy.c
U Zope3/trunk/src/zope/app/demo/jobboard/joblistview.pt
U Zope3/trunk/src/zope/app/dublincore/tests/test_dcsv.py
U Zope3/trunk/src/zope/app/error/error.py
U Zope3/trunk/src/zope/app/fssync/browser/__init__.py
U Zope3/trunk/src/zope/app/fssync/committer.py
U Zope3/trunk/src/zope/app/fssync/fspickle.py
U Zope3/trunk/src/zope/app/fssync/tests/test_committer.py
U Zope3/trunk/src/zope/app/onlinehelp/onlinehelptopic.py
U Zope3/trunk/src/zope/app/pagetemplate/engine.py
U Zope3/trunk/src/zope/app/publisher/browser/__init__.py
U Zope3/trunk/src/zope/app/publisher/browser/viewmeta.py
U Zope3/trunk/src/zope/app/renderer/metaconfigure.py
U Zope3/trunk/src/zope/app/rotterdam/zope3.css
U Zope3/trunk/src/zope/app/rotterdam/zope3_tablelayout.css
U Zope3/trunk/src/zope/app/schema/tests/test_wrapper.py
U Zope3/trunk/src/zope/app/schema/wrapper.py
U Zope3/trunk/src/zope/app/security/basicauthadapter.py
U Zope3/trunk/src/zope/app/security/tests/test_adapter.py
U Zope3/trunk/src/zope/app/securitypolicy/browser/grant.pt
U Zope3/trunk/src/zope/app/server/DEPENDENCIES.cfg
U Zope3/trunk/src/zope/app/server/mkzopeinstance.py
U Zope3/trunk/src/zope/app/session/DEPENDENCIES.cfg
U Zope3/trunk/src/zope/app/testing/functional.py
U Zope3/trunk/src/zope/app/traversing/namespace.py
U Zope3/trunk/src/zope/app/traversing/tests/test_conveniencefunctions.py
U Zope3/trunk/src/zope/app/versioncontrol/interfaces.py
U Zope3/trunk/src/zope/app/versioncontrol/repository.py
U Zope3/trunk/src/zope/app/versioncontrol/utility.py
U Zope3/trunk/src/zope/app/workflow/stateful/browser/addtransition.pt
U Zope3/trunk/src/zope/app/workflow/stateful/instance.py
U Zope3/trunk/src/zope/documenttemplate/tests/testdt_var.py
U Zope3/trunk/src/zope/i18nmessageid/message.py
U Zope3/trunk/src/zope/interface/README.txt
U Zope3/trunk/src/zope/interface/tests/test_odd_declarations.py
U Zope3/trunk/src/zope/proxy/_zope_proxy_proxy.c
U Zope3/trunk/src/zope/schema/tests/test_tuplefield.py
U Zope3/trunk/src/zope/server/ftp/tests/test_ftpserver.py
U Zope3/trunk/src/zope/server/http/publisherhttpserver.py
U Zope3/trunk/src/zope/server/http/tests/test_httpserver.py
U Zope3/trunk/src/zope/structuredtext/stdom.py
U Zope3/trunk/src/zope/structuredtext/tests.py
U Zope3/trunk/src/zope/tal/tests/run.py
U Zope3/trunk/src/zope/wfmc/xpdl.py
-=-
Modified: Zope3/trunk/src/zope/app/component/browser/configure.zcml
===================================================================
--- Zope3/trunk/src/zope/app/component/browser/configure.zcml 2005-07-29 17:52:01 UTC (rev 37556)
+++ Zope3/trunk/src/zope/app/component/browser/configure.zcml 2005-07-29 18:19:31 UTC (rev 37557)
@@ -8,7 +8,7 @@
<!-- Registration Managemenet -->
<!-- BBB: Gone with 3.3 -->
- <!-- XXX
+ <!--
<zope:view
for="zope.app.component.interfaces.registration.IComponentPath"
type="zope.publisher.interfaces.browser.IBrowserRequest"
@@ -256,7 +256,7 @@
<!-- Adapter Registration -->
- <!--XXX: addform
+ <!-- addform
label="New Adapter Registration"
schema="zope.app.component.interfaces.IAdapterRegistration"
name="addRegistration.html"
@@ -268,7 +268,7 @@
menu="add_registration" title="Adapter Registration"
/-->
- <!-- XXX: addMenuItem
+ <!-- addMenuItem
view="addAdapterRegistration.html"
class="zope.app.component.site.AdapterRegistration"
permission="zope.ManageSite"
Modified: Zope3/trunk/src/zope/app/component/configure.zcml
===================================================================
--- Zope3/trunk/src/zope/app/component/configure.zcml 2005-07-29 17:52:01 UTC (rev 37556)
+++ Zope3/trunk/src/zope/app/component/configure.zcml 2005-07-29 18:19:31 UTC (rev 37557)
@@ -89,7 +89,7 @@
zope.app.container.interfaces.IWriteContainer" />
</content>
- <!-- XXX: We allow these attributes to be changed. We need some subscriber
+ <!-- TODO: We allow these attributes to be changed. We need some subscriber
that updated the registries once attributes change. -->
<content class=".site.AdapterRegistration">
<require
Modified: Zope3/trunk/src/zope/app/component/registration.py
===================================================================
--- Zope3/trunk/src/zope/app/component/registration.py 2005-07-29 17:52:01 UTC (rev 37556)
+++ Zope3/trunk/src/zope/app/component/registration.py 2005-07-29 18:19:31 UTC (rev 37557)
@@ -145,7 +145,7 @@
if objectstatus == interfaces.ActiveStatus:
try:
objectpath = zapi.getPath(registration)
- except: # XXX
+ except: # TODO decide if this is really the best fall-back plan
objectpath = str(registration)
msg = _("Can't delete active registration (${path})")
msg.mapping["path"] = objectpath
Modified: Zope3/trunk/src/zope/app/container/_zope_app_container_contained.c
===================================================================
--- Zope3/trunk/src/zope/app/container/_zope_app_container_contained.c 2005-07-29 17:52:01 UTC (rev 37556)
+++ Zope3/trunk/src/zope/app/container/_zope_app_container_contained.c 2005-07-29 18:19:31 UTC (rev 37557)
@@ -245,7 +245,7 @@
static int
CP_clear(ProxyObject *self)
{
- /* XXXX Drop references that may have created reference
+ /* Drop references that may have created reference
cycles. Immutable objects do not have to define this method
since they can never directly create reference cycles. Note
that the object must still be valid after calling this
Modified: Zope3/trunk/src/zope/app/container/_zope_proxy_proxy.c
===================================================================
--- Zope3/trunk/src/zope/app/container/_zope_proxy_proxy.c 2005-07-29 17:52:01 UTC (rev 37556)
+++ Zope3/trunk/src/zope/app/container/_zope_proxy_proxy.c 2005-07-29 18:19:31 UTC (rev 37557)
@@ -429,7 +429,7 @@
result = operation(Proxy_GET_OBJECT(self));
#if 0
if (result != NULL)
- /* XXX create proxy for result? */
+ /* ??? create proxy for result? */
;
#endif
return result;
@@ -456,7 +456,7 @@
}
#if 0
if (result != NULL)
- /* XXX create proxy for result? */
+ /* ??? create proxy for result? */
;
#endif
return result;
@@ -479,7 +479,7 @@
}
#if 0
else if (result != NULL)
- /* XXX create proxy for result? */
+ /* ??? create proxy for result? */
;
#endif
return result;
@@ -563,10 +563,10 @@
}
#if 0
else {
- /* XXX create proxy for left? */
+ /* ??? create proxy for left? */
}
if (right != other) {
- /* XXX create proxy for right? */
+ /* ??? create proxy for right? */
}
#endif
*p_self = left;
Modified: Zope3/trunk/src/zope/app/demo/jobboard/joblistview.pt
===================================================================
--- Zope3/trunk/src/zope/app/demo/jobboard/joblistview.pt 2005-07-29 17:52:01 UTC (rev 37556)
+++ Zope3/trunk/src/zope/app/demo/jobboard/joblistview.pt 2005-07-29 18:19:31 UTC (rev 37557)
@@ -19,7 +19,7 @@
</tr>
</table>
-<!-- XXX this should only appear if the user has the proper permissions -->
+<!-- TODO this should only appear if the user has the proper permissions -->
<h2 i18n:translate="other-operations">Other operations</h2>
<a href="review.html"
i18n:translate="approve-submitted-jobs">Approve submitted jobs</a>
Modified: Zope3/trunk/src/zope/app/dublincore/tests/test_dcsv.py
===================================================================
--- Zope3/trunk/src/zope/app/dublincore/tests/test_dcsv.py 2005-07-29 17:52:01 UTC (rev 37556)
+++ Zope3/trunk/src/zope/app/dublincore/tests/test_dcsv.py 2005-07-29 18:19:31 UTC (rev 37557)
@@ -21,7 +21,7 @@
from zope.app.dublincore.dcsv import encode, decode
-# XXX still need tests for errors, and createMapping()
+# TODO still need tests for errors, and createMapping()
def test_decode_empty():
@@ -107,7 +107,7 @@
"""
def test_decode_empty_values():
- # XXX weird case; hard to know the intent of the specification
+ # weird case; hard to know the intent of the specification
"""
>>> decode('=')
[('', '')]
Modified: Zope3/trunk/src/zope/app/error/error.py
===================================================================
--- Zope3/trunk/src/zope/app/error/error.py 2005-07-29 17:52:01 UTC (rev 37556)
+++ Zope3/trunk/src/zope/app/error/error.py 2005-07-29 18:19:31 UTC (rev 37557)
@@ -15,7 +15,7 @@
This is a port of the Zope 2 error reporting object
-$Id: __init__.py 26735 2004-07-23 22:04:28Z pruggera $
+$Id$
"""
__docformat__ = 'restructuredtext'
@@ -97,12 +97,12 @@
username = None
req_html = None
if request:
- # XXX: Temporary fix, which Steve should undo. URL is
+ # TODO: Temporary fix, which Steve should undo. URL is
# just too HTTPRequest-specific.
if hasattr(request, 'URL'):
url = request.URL
try:
- # XXX: UnauthenticatedPrincipal does not have getLogin()
+ # UnauthenticatedPrincipal does not have getLogin()
if hasattr(request.principal, 'getLogin'):
login = request.principal.getLogin()
else:
@@ -114,12 +114,11 @@
)])
# When there's an unauthorized access, request.principal is
# not set, so we get an AttributeError
- # XXX is this right? Surely request.principal should be set!
- # XXX Answer: Catching AttributeError is correct for the
- # simple reason that UnauthenticatedUser (which
- # I always use during coding), has no 'getLogin()'
- # method. However, for some reason this except
- # does **NOT** catch these errors.
+ # ??? Is this right? Surely request.principal should be set!
+ # !!! Yes. Catching AttributeError is correct for the simple
+ # reason that UnauthenticatedUser (which I always use during
+ # coding), has no 'getLogin()' method. However, for some reason
+ # this except does **NOT** catch these errors.
except AttributeError:
pass
@@ -165,7 +164,7 @@
info = None
def _do_copy_to_zlog(self, now, strtype, url, info):
- # XXX info is unused; logging.exception() will call sys.exc_info()
+ # info is unused; logging.exception() will call sys.exc_info()
# work around this with an evil hack
when = _rate_restrict_pool.get(strtype,0)
if now > when:
Modified: Zope3/trunk/src/zope/app/fssync/browser/__init__.py
===================================================================
--- Zope3/trunk/src/zope/app/fssync/browser/__init__.py 2005-07-29 17:52:01 UTC (rev 37556)
+++ Zope3/trunk/src/zope/app/fssync/browser/__init__.py 2005-07-29 18:19:31 UTC (rev 37557)
@@ -146,7 +146,7 @@
"""
def run_submission(self):
- # XXX need to make sure the top-level name doesn't already
+ # TODO need to make sure the top-level name doesn't already
# exist, or existing site data can get screwed
self.call_committer()
return ""
Modified: Zope3/trunk/src/zope/app/fssync/committer.py
===================================================================
--- Zope3/trunk/src/zope/app/fssync/committer.py 2005-07-29 17:52:01 UTC (rev 37556)
+++ Zope3/trunk/src/zope/app/fssync/committer.py 2005-07-29 18:19:31 UTC (rev 37557)
@@ -354,7 +354,7 @@
adapter.setBody(newdata)
# Now publish an event, but not for annotations or
# extras. To know which case we have, see if
- # getName() works. XXX This is a hack.
+ # getName() works. *** This is a hack. ***
try:
getName(obj)
except:
Modified: Zope3/trunk/src/zope/app/fssync/fspickle.py
===================================================================
--- Zope3/trunk/src/zope/app/fssync/fspickle.py 2005-07-29 17:52:01 UTC (rev 37556)
+++ Zope3/trunk/src/zope/app/fssync/fspickle.py 2005-07-29 18:19:31 UTC (rev 37557)
@@ -146,7 +146,7 @@
if location.inside(object, self.location):
return None
elif object is self.parent:
- # XXX emit special parent marker
+ # emit special parent marker
return PARENT_MARKER
elif location.inside(object, self.root):
return LocationPhysicallyLocatable(object).getPath()
Modified: Zope3/trunk/src/zope/app/fssync/tests/test_committer.py
===================================================================
--- Zope3/trunk/src/zope/app/fssync/tests/test_committer.py 2005-07-29 17:52:01 UTC (rev 37556)
+++ Zope3/trunk/src/zope/app/fssync/tests/test_committer.py 2005-07-29 18:19:31 UTC (rev 37557)
@@ -533,9 +533,9 @@
self.fooentry.clear()
self.check_no_errors()
- # XXX Extra and Annotations is not tested directly
+ # TODO Extra and Annotations is not tested directly
- # XXX Changing directories into files or vice versa is not tested
+ # TODO Changing directories into files or vice versa is not tested
Modified: Zope3/trunk/src/zope/app/onlinehelp/onlinehelptopic.py
===================================================================
--- Zope3/trunk/src/zope/app/onlinehelp/onlinehelptopic.py 2005-07-29 17:52:01 UTC (rev 37556)
+++ Zope3/trunk/src/zope/app/onlinehelp/onlinehelptopic.py 2005-07-29 18:19:31 UTC (rev 37557)
@@ -475,7 +475,7 @@
raise NotFound(self, name, request)
- # XXX: we need some unittests for this !!!
+ # TODO: we need some unittests for this !!!
def __getitem__(self, name):
return self.index.macros[name]
Modified: Zope3/trunk/src/zope/app/pagetemplate/engine.py
===================================================================
--- Zope3/trunk/src/zope/app/pagetemplate/engine.py 2005-07-29 17:52:01 UTC (rev 37556)
+++ Zope3/trunk/src/zope/app/pagetemplate/engine.py 2005-07-29 18:19:31 UTC (rev 37557)
@@ -123,7 +123,7 @@
'you cannot have inline code snippets in your Page '
'Template. Activate Inline Code Evaluation and try again.')
- # XXX This is only needed when self.evaluateInlineCode is true,
+ # TODO This is only needed when self.evaluateInlineCode is true,
# so should only be needed for zope.app.pythonpage.
from zope.app.interpreter.interfaces import IInterpreter
interpreter = zapi.queryUtility(IInterpreter, lang)
Modified: Zope3/trunk/src/zope/app/publisher/browser/__init__.py
===================================================================
--- Zope3/trunk/src/zope/app/publisher/browser/__init__.py 2005-07-29 17:52:01 UTC (rev 37556)
+++ Zope3/trunk/src/zope/app/publisher/browser/__init__.py 2005-07-29 18:19:31 UTC (rev 37557)
@@ -24,7 +24,7 @@
from zope.app.publisher.interfaces.browser import IBrowserView
from zope.publisher.interfaces.browser import ISkin
-# XXX: needs testing of __parent__ property
+# TODO: needs testing of __parent__ property
class BrowserView(Location):
implements(IBrowserView)
@@ -67,7 +67,7 @@
a context.
"""
-# XXX: needs tests
+# TODO: needs tests
def getDefaultViewName(object, request, context=None):
name = queryDefaultViewName(object, request, context=context)
if name is not None:
Modified: Zope3/trunk/src/zope/app/publisher/browser/viewmeta.py
===================================================================
--- Zope3/trunk/src/zope/app/publisher/browser/viewmeta.py 2005-07-29 17:52:01 UTC (rev 37556)
+++ Zope3/trunk/src/zope/app/publisher/browser/viewmeta.py 2005-07-29 18:19:31 UTC (rev 37557)
@@ -117,7 +117,7 @@
raise ConfigurationError("No such file", template)
required['__getitem__'] = permission
- # XXX: new __name__ attribute must be tested
+ # TODO: new __name__ attribute must be tested
if class_:
if attribute != '__call__':
if not hasattr(class_, attribute):
Modified: Zope3/trunk/src/zope/app/renderer/metaconfigure.py
===================================================================
--- Zope3/trunk/src/zope/app/renderer/metaconfigure.py 2005-07-29 17:52:01 UTC (rev 37556)
+++ Zope3/trunk/src/zope/app/renderer/metaconfigure.py 2005-07-29 18:19:31 UTC (rev 37557)
@@ -41,7 +41,7 @@
u"view on the source.",
required=True)
-# XXX: Does not seem to be tested
+# TODO: Does not seem to be tested
def renderer(_context, sourceType, for_, factory):
_context.action(
discriminator = ('view', sourceType, u'', for_, 'default'),
Modified: Zope3/trunk/src/zope/app/rotterdam/zope3.css
===================================================================
--- Zope3/trunk/src/zope/app/rotterdam/zope3.css 2005-07-29 17:52:01 UTC (rev 37556)
+++ Zope3/trunk/src/zope/app/rotterdam/zope3.css 2005-07-29 18:19:31 UTC (rev 37557)
@@ -355,8 +355,8 @@
}
*/
-/* XXX: div.row div.field doesn't appear to be selecting. div.row div
- is a workaround */
+/* div.row div.field doesn't appear to be selecting. div.row div
+ is a workaround */
/* This seems to work in Firefox 1.0 and IE6. */
div.row div.field {
Modified: Zope3/trunk/src/zope/app/rotterdam/zope3_tablelayout.css
===================================================================
--- Zope3/trunk/src/zope/app/rotterdam/zope3_tablelayout.css 2005-07-29 17:52:01 UTC (rev 37556)
+++ Zope3/trunk/src/zope/app/rotterdam/zope3_tablelayout.css 2005-07-29 18:19:31 UTC (rev 37557)
@@ -462,8 +462,8 @@
}
*/
-/* XXX: div.row div.field doesn't appear to be selecting. div.row div
- is a workaround */
+/* div.row div.field doesn't appear to be selecting. div.row div
+ is a workaround */
/* This seems to work in Firefox 1.0 and IE6. */
div.row div.field {
Modified: Zope3/trunk/src/zope/app/schema/tests/test_wrapper.py
===================================================================
--- Zope3/trunk/src/zope/app/schema/tests/test_wrapper.py 2005-07-29 17:52:01 UTC (rev 37556)
+++ Zope3/trunk/src/zope/app/schema/tests/test_wrapper.py 2005-07-29 18:19:31 UTC (rev 37557)
@@ -189,7 +189,7 @@
p._p_jar = dm
p._p_changed = 0
p._p_deactivate()
- # XXX does this really test the activate method?
+ # ??? does this really test the activate method?
p._p_activate()
self.assertEqual(p._p_state, UPTODATE)
self.assertEqual(p.x, 42)
@@ -208,7 +208,7 @@
self.assertEqual(p._p_state, UPTODATE)
self.assertEqual(p.x, 42)
-# XXX to do this right and expose both IPersistent and the
+# To do this right and expose both IPersistent and the
# underlying object's interfaces, we'd need to use a specialized
# descriptor. This would create to great a dependency on
# zope.interface.
Modified: Zope3/trunk/src/zope/app/schema/wrapper.py
===================================================================
--- Zope3/trunk/src/zope/app/schema/wrapper.py 2005-07-29 17:52:01 UTC (rev 37556)
+++ Zope3/trunk/src/zope/app/schema/wrapper.py 2005-07-29 18:19:31 UTC (rev 37557)
@@ -30,7 +30,7 @@
if inst is None:
return selectChecker(cls)
else:
- # XXX This is *VERY* tricky. There is a possibility that
+ # This is *VERY* tricky. There is a possibility that
# the object was loaded, but not active by the time
# __proxied__ needs to be accessed, which results
# in an AttributeError here, which is swallowed
@@ -73,7 +73,7 @@
made through external attribute assignments.
"""
- # XXX to do this right and expose both IPersistent and the
+ # TODO to do this right and expose both IPersistent and the
# underlying object's interfaces, we'd need to use a specialized
# descriptor. This would create to great a dependency on
# zope.interface.
@@ -93,7 +93,7 @@
if hasattr(v, '__get__'):
return v.__get__(self, type(self))
return v
- # XXX This is butt ugly. See the comment on SecurityDescriptor.
+ # TODO This is butt ugly. See the comment on SecurityDescriptor.
if self._p_state == GHOST:
self._p_activate()
proxied = self.__proxied__
Modified: Zope3/trunk/src/zope/app/security/basicauthadapter.py
===================================================================
--- Zope3/trunk/src/zope/app/security/basicauthadapter.py 2005-07-29 17:52:01 UTC (rev 37556)
+++ Zope3/trunk/src/zope/app/security/basicauthadapter.py 2005-07-29 18:19:31 UTC (rev 37557)
@@ -28,7 +28,7 @@
def __init__(self, request):
self.__request = request
- # XXX base64 decoding should be done here, not in request
+ # TODO base64 decoding should be done here, not in request
lpw = request._authUserPW()
if lpw is None:
login, password = None, None
Modified: Zope3/trunk/src/zope/app/security/tests/test_adapter.py
===================================================================
--- Zope3/trunk/src/zope/app/security/tests/test_adapter.py 2005-07-29 17:52:01 UTC (rev 37556)
+++ Zope3/trunk/src/zope/app/security/tests/test_adapter.py 2005-07-29 18:19:31 UTC (rev 37557)
@@ -11,8 +11,7 @@
# FOR A PARTICULAR PURPOSE.
#
##############################################################################
-"""XXX short summary goes here.
-
+"""
$Id$
"""
import unittest
Modified: Zope3/trunk/src/zope/app/securitypolicy/browser/grant.pt
===================================================================
--- Zope3/trunk/src/zope/app/securitypolicy/browser/grant.pt 2005-07-29 17:52:01 UTC (rev 37556)
+++ Zope3/trunk/src/zope/app/securitypolicy/browser/grant.pt 2005-07-29 18:19:31 UTC (rev 37557)
@@ -2,8 +2,8 @@
i18n:domain="zope">
<body>
-<!-- XXX : This is just a temporary way of overriding the elements not needed,
- only done for visual purposes. Do not clone this ;)
+<!-- This is just a temporary way of overriding the elements not needed,
+ only done for visual purposes. Do not clone this ;)
- Alexander
-->
<div metal:fill-slot="tabs" />
Modified: Zope3/trunk/src/zope/app/server/DEPENDENCIES.cfg
===================================================================
--- Zope3/trunk/src/zope/app/server/DEPENDENCIES.cfg 2005-07-29 17:52:01 UTC (rev 37556)
+++ Zope3/trunk/src/zope/app/server/DEPENDENCIES.cfg 2005-07-29 18:19:31 UTC (rev 37557)
@@ -1,5 +1,4 @@
-# XXX I have no idea
+# TODO: Figure out what these should be.
ThreadedAsync
ZConfig
zdaemon
-
Modified: Zope3/trunk/src/zope/app/server/mkzopeinstance.py
===================================================================
--- Zope3/trunk/src/zope/app/server/mkzopeinstance.py 2005-07-29 17:52:01 UTC (rev 37556)
+++ Zope3/trunk/src/zope/app/server/mkzopeinstance.py 2005-07-29 18:19:31 UTC (rev 37557)
@@ -165,7 +165,7 @@
def copy_skeleton(self):
options = self.options
- # XXX we should be able to compute the script
+ # TODO we should be able to compute the script
script = os.path.abspath(sys.argv[0])
zope_home = os.path.dirname(os.path.dirname(script))
zope_init = os.path.abspath(zope.__file__)
Modified: Zope3/trunk/src/zope/app/session/DEPENDENCIES.cfg
===================================================================
--- Zope3/trunk/src/zope/app/session/DEPENDENCIES.cfg 2005-07-29 17:52:01 UTC (rev 37556)
+++ Zope3/trunk/src/zope/app/session/DEPENDENCIES.cfg 2005-07-29 18:19:31 UTC (rev 37557)
@@ -6,6 +6,6 @@
zope.publisher
zope.schema
-# XXX This dependency is bad. It reflects use of a utility function
+# TODO This dependency is bad. It reflects use of a utility function
# that should be copied elsewhere:
zope.server
Modified: Zope3/trunk/src/zope/app/testing/functional.py
===================================================================
--- Zope3/trunk/src/zope/app/testing/functional.py 2005-07-29 17:52:01 UTC (rev 37556)
+++ Zope3/trunk/src/zope/app/testing/functional.py 2005-07-29 18:19:31 UTC (rev 37557)
@@ -96,7 +96,7 @@
class IManagerSetup(zope.interface.Interface):
"""Utility for enabling up a functional testing manager with needed grants
- XXX This is an interim solution. It tries to break the dependence
+ TODO This is an interim solution. It tries to break the dependence
on a particular security policy, however, we need a much better
way of managing functional-testing configurations.
"""
@@ -346,7 +346,7 @@
a = base + a
if a.find('#') != -1:
a = a[:a.index('#') - 1]
- # XXX what about queries (/path/to/foo?bar=baz&etc)?
+ # ??? what about queries (/path/to/foo?bar=baz&etc)?
request = None
try:
try:
Modified: Zope3/trunk/src/zope/app/traversing/namespace.py
===================================================================
--- Zope3/trunk/src/zope/app/traversing/namespace.py 2005-07-29 17:52:01 UTC (rev 37556)
+++ Zope3/trunk/src/zope/app/traversing/namespace.py 2005-07-29 18:19:31 UTC (rev 37557)
@@ -255,7 +255,7 @@
traversable = ITraversable(ob, None)
if traversable is not None:
try:
- # XXX what do we do if the path gets bigger?
+ # ??? what do we do if the path gets bigger?
path = []
next = traversable.traverse(name, path)
if path:
Modified: Zope3/trunk/src/zope/app/traversing/tests/test_conveniencefunctions.py
===================================================================
--- Zope3/trunk/src/zope/app/traversing/tests/test_conveniencefunctions.py 2005-07-29 17:52:01 UTC (rev 37556)
+++ Zope3/trunk/src/zope/app/traversing/tests/test_conveniencefunctions.py 2005-07-29 18:19:31 UTC (rev 37557)
@@ -106,7 +106,7 @@
self.tr.traverse('/folder')
)
- # XXX test that ++names++ and @@names work too
+ # TODO test that ++names++ and @@names work too
def testTraverseNameBadValue(self):
from zope.app.traversing.api import traverseName
Modified: Zope3/trunk/src/zope/app/versioncontrol/interfaces.py
===================================================================
--- Zope3/trunk/src/zope/app/versioncontrol/interfaces.py 2005-07-29 17:52:01 UTC (rev 37556)
+++ Zope3/trunk/src/zope/app/versioncontrol/interfaces.py 2005-07-29 18:19:31 UTC (rev 37557)
@@ -290,7 +290,7 @@
object to a revision. `data` is a value provided by the
`getNonVersionedData()` method of this instance.
- XXX question for Gary:
+ ??? question:
This should not overwrite data that exists in the object but
that is included in the passed-in data.
Modified: Zope3/trunk/src/zope/app/versioncontrol/repository.py
===================================================================
--- Zope3/trunk/src/zope/app/versioncontrol/repository.py 2005-07-29 17:52:01 UTC (rev 37556)
+++ Zope3/trunk/src/zope/app/versioncontrol/repository.py 2005-07-29 18:19:31 UTC (rev 37557)
@@ -84,7 +84,7 @@
"""Internal: replace the state of a persistent object.
"""
non_versioned = nonversioned.getNonVersionedData(obj)
- # XXX There ought to be some way to do this more cleanly.
+ # TODO There ought to be some way to do this more cleanly.
# This fills the __dict__ of the old object with new state.
# The other way to achieve the desired effect is to replace
# the object in its container, but this method preserves the
Modified: Zope3/trunk/src/zope/app/versioncontrol/utility.py
===================================================================
--- Zope3/trunk/src/zope/app/versioncontrol/utility.py 2005-07-29 17:52:01 UTC (rev 37556)
+++ Zope3/trunk/src/zope/app/versioncontrol/utility.py 2005-07-29 18:19:31 UTC (rev 37557)
@@ -81,7 +81,7 @@
if not isinstance(s, str):
return None
- # XXX obviously no test for this
+ # TODO obviously no test for this
if (zope.app.location.ILocation.providedBy(ob)
and not zope.app.location.inside(ob, object)):
return '1' # go away
Modified: Zope3/trunk/src/zope/app/workflow/stateful/browser/addtransition.pt
===================================================================
--- Zope3/trunk/src/zope/app/workflow/stateful/browser/addtransition.pt 2005-07-29 17:52:01 UTC (rev 37556)
+++ Zope3/trunk/src/zope/app/workflow/stateful/browser/addtransition.pt 2005-07-29 18:19:31 UTC (rev 37557)
@@ -45,7 +45,7 @@
<div class="row">
<div class="label" i18n:translate="">Permission</div>
<div class="field">
- <!-- XXX: This should be really a Permission widget -->
+ <!-- TODO: This should be really a Permission widget -->
<input type="text" name="permission" size="40" value="" />
</div>
</div>
Modified: Zope3/trunk/src/zope/app/workflow/stateful/instance.py
===================================================================
--- Zope3/trunk/src/zope/app/workflow/stateful/instance.py 2005-07-29 17:52:01 UTC (rev 37556)
+++ Zope3/trunk/src/zope/app/workflow/stateful/instance.py 2005-07-29 18:19:31 UTC (rev 37557)
@@ -276,7 +276,7 @@
if not script:
return True
if isinstance(script, (str, unicode)):
- # XXX: not tested!
+ # TODO: not tested!
script = resolve(script)
return script(contexts)
Modified: Zope3/trunk/src/zope/documenttemplate/tests/testdt_var.py
===================================================================
--- Zope3/trunk/src/zope/documenttemplate/tests/testdt_var.py 2005-07-29 17:52:01 UTC (rev 37556)
+++ Zope3/trunk/src/zope/documenttemplate/tests/testdt_var.py 2005-07-29 18:19:31 UTC (rev 37557)
@@ -15,8 +15,10 @@
$Id$
"""
-# XXX Don't normalize whitespace in this file -- the tests depend on the
-# whitespace in the triple quoted strings.
+# ****************************************************************************
+# *** Don't normalize whitespace in this file -- the tests depend on the ***
+# *** whitespace in the triple quoted strings. ***
+# ****************************************************************************
import unittest
from zope.documenttemplate.tests.dtmltestbase import DTMLTestBase
Modified: Zope3/trunk/src/zope/i18nmessageid/message.py
===================================================================
--- Zope3/trunk/src/zope/i18nmessageid/message.py 2005-07-29 17:52:01 UTC (rev 37556)
+++ Zope3/trunk/src/zope/i18nmessageid/message.py 2005-07-29 18:19:31 UTC (rev 37557)
@@ -147,7 +147,7 @@
ustr = unicode(ustr)
self.domain = domain
if default is None:
- # XXX MessageID does: self.default = ustr
+ # MessageID does: self.default = ustr
self.default = default
else:
self.default = unicode(default)
Modified: Zope3/trunk/src/zope/interface/README.txt
===================================================================
--- Zope3/trunk/src/zope/interface/README.txt 2005-07-29 17:52:01 UTC (rev 37556)
+++ Zope3/trunk/src/zope/interface/README.txt 2005-07-29 18:19:31 UTC (rev 37557)
@@ -693,5 +693,5 @@
object that provides IBaz should be usable whereever an
object that provides IBlat is expected.
- The interface implementation doesn't enforce this. XXX
+ The interface implementation doesn't enforce this.
but maybe it should do some checks.
Modified: Zope3/trunk/src/zope/interface/tests/test_odd_declarations.py
===================================================================
--- Zope3/trunk/src/zope/interface/tests/test_odd_declarations.py 2005-07-29 17:52:01 UTC (rev 37556)
+++ Zope3/trunk/src/zope/interface/tests/test_odd_declarations.py 2005-07-29 18:19:31 UTC (rev 37557)
@@ -168,7 +168,7 @@
def test_directlyProvides_fails_for_odd_class(self):
self.assertRaises(TypeError, directlyProvides, C, I5)
- # XXX see above
+ # see above
def XXX_test_classProvides_fails_for_odd_class(self):
try:
class A(Odd):
Modified: Zope3/trunk/src/zope/proxy/_zope_proxy_proxy.c
===================================================================
--- Zope3/trunk/src/zope/proxy/_zope_proxy_proxy.c 2005-07-29 17:52:01 UTC (rev 37556)
+++ Zope3/trunk/src/zope/proxy/_zope_proxy_proxy.c 2005-07-29 18:19:31 UTC (rev 37557)
@@ -429,7 +429,7 @@
result = operation(Proxy_GET_OBJECT(self));
#if 0
if (result != NULL)
- /* XXX create proxy for result? */
+ /* ??? create proxy for result? */
;
#endif
return result;
@@ -456,7 +456,7 @@
}
#if 0
if (result != NULL)
- /* XXX create proxy for result? */
+ /* ??? create proxy for result? */
;
#endif
return result;
@@ -479,7 +479,7 @@
}
#if 0
else if (result != NULL)
- /* XXX create proxy for result? */
+ /* ??? create proxy for result? */
;
#endif
return result;
@@ -563,10 +563,10 @@
}
#if 0
else {
- /* XXX create proxy for left? */
+ /* ??? create proxy for left? */
}
if (right != other) {
- /* XXX create proxy for right? */
+ /* ??? create proxy for right? */
}
#endif
*p_self = left;
Modified: Zope3/trunk/src/zope/schema/tests/test_tuplefield.py
===================================================================
--- Zope3/trunk/src/zope/schema/tests/test_tuplefield.py 2005-07-29 17:52:01 UTC (rev 37556)
+++ Zope3/trunk/src/zope/schema/tests/test_tuplefield.py 2005-07-29 18:19:31 UTC (rev 37557)
@@ -96,7 +96,7 @@
self.assertRaises(WrongContainedType, field.validate, (3.14159,) )
def testCorrectValueType(self):
- # allow value_type of None (XXX)
+ # allow value_type of None (??? is this OK?)
Tuple(value_type=None)
# do not allow arbitrary value types
Modified: Zope3/trunk/src/zope/server/ftp/tests/test_ftpserver.py
===================================================================
--- Zope3/trunk/src/zope/server/ftp/tests/test_ftpserver.py 2005-07-29 17:52:01 UTC (rev 37556)
+++ Zope3/trunk/src/zope/server/ftp/tests/test_ftpserver.py 2005-07-29 18:19:31 UTC (rev 37557)
@@ -56,7 +56,7 @@
td.setThreadCount(1)
if len(asyncore.socket_map) != 1:
# Let sockets die off.
- # XXX tests should be more careful to clear the socket map.
+ # TODO tests should be more careful to clear the socket map.
asyncore.poll(0.1)
self.orig_map_size = len(asyncore.socket_map)
self.hook_asyncore_error()
@@ -249,9 +249,9 @@
def XXXtestHELP(self):
- # XXX This test doesn't work. I think it is because execute()
- # doesn't read the whole reply. The execeute() helper
- # function should be fixed, but that's for another day.
+ # TODO This test doesn't work. I think it is because execute()
+ # doesn't read the whole reply. The execeute() helper
+ # function should be fixed, but that's for another day.
result = status_messages['HELP_START'] + '\r\n'
result += 'Help goes here somewhen.\r\n'
result += status_messages['HELP_END']
Modified: Zope3/trunk/src/zope/server/http/publisherhttpserver.py
===================================================================
--- Zope3/trunk/src/zope/server/http/publisherhttpserver.py 2005-07-29 17:52:01 UTC (rev 37556)
+++ Zope3/trunk/src/zope/server/http/publisherhttpserver.py 2005-07-29 18:19:31 UTC (rev 37557)
@@ -25,7 +25,7 @@
def __init__(self, request_factory, sub_protocol=None, *args, **kw):
- # XXX This 'adjustment' to args[0] (the hostname for the HTTP server)
+ # This 'adjustment' to args[0] (the hostname for the HTTP server)
# under Windows is to get Zope to accept connections from other machines
# when the host name is omitted from the server address (in zope.conf).
# The address comes in as 'localhost' from ZConfig by way of some
Modified: Zope3/trunk/src/zope/server/http/tests/test_httpserver.py
===================================================================
--- Zope3/trunk/src/zope/server/http/tests/test_httpserver.py 2005-07-29 17:52:01 UTC (rev 37556)
+++ Zope3/trunk/src/zope/server/http/tests/test_httpserver.py 2005-07-29 18:19:31 UTC (rev 37557)
@@ -80,7 +80,7 @@
td.setThreadCount(4)
if len(socket_map) != 1:
# Let sockets die off.
- # XXX tests should be more careful to clear the socket map.
+ # TODO tests should be more careful to clear the socket map.
poll(0.1)
self.orig_map_size = len(socket_map)
self.hook_asyncore_error()
Modified: Zope3/trunk/src/zope/structuredtext/stdom.py
===================================================================
--- Zope3/trunk/src/zope/structuredtext/stdom.py 2005-07-29 17:52:01 UTC (rev 37556)
+++ Zope3/trunk/src/zope/structuredtext/stdom.py 2005-07-29 18:19:31 UTC (rev 37557)
@@ -127,7 +127,7 @@
n=TextNode(n)
return n.__of__(self)
-#XXX ugh
+
class NodeWrapper(ParentNode):
"""
This is an acquisition-like wrapper that provides parent access for
@@ -220,7 +220,6 @@
"""
# Get a DOM wrapper with a parent link
- #XXX ugh
def __of__(self, parent):
return NodeWrapper(self, parent)
Modified: Zope3/trunk/src/zope/structuredtext/tests.py
===================================================================
--- Zope3/trunk/src/zope/structuredtext/tests.py 2005-07-29 17:52:01 UTC (rev 37556)
+++ Zope3/trunk/src/zope/structuredtext/tests.py 2005-07-29 18:19:31 UTC (rev 37557)
@@ -112,7 +112,7 @@
self._test("this is a '\"literal\":http://www.zope.org/.' eh",
'<code>"literal":http://www.zope.org/.</code>')
- # XXX need unicode tests
+ # TODO need unicode tests
def test_suite():
Modified: Zope3/trunk/src/zope/tal/tests/run.py
===================================================================
--- Zope3/trunk/src/zope/tal/tests/run.py 2005-07-29 17:52:01 UTC (rev 37556)
+++ Zope3/trunk/src/zope/tal/tests/run.py 2005-07-29 18:19:31 UTC (rev 37557)
@@ -14,7 +14,7 @@
##############################################################################
"""Run all tests.
-$Id: $
+$Id$
"""
import sys
import unittest
@@ -25,7 +25,7 @@
from zope.tal.tests import test_files
from zope.tal.tests import test_sourcepos
-# XXX this code isn't picked up by the Zope 3 test framework..
+# TODO this code isn't picked up by the Zope 3 test framework..
def test_suite():
suite = unittest.TestSuite()
suite.addTest(test_htmltalparser.test_suite())
Modified: Zope3/trunk/src/zope/wfmc/xpdl.py
===================================================================
--- Zope3/trunk/src/zope/wfmc/xpdl.py 2005-07-29 17:52:01 UTC (rev 37556)
+++ Zope3/trunk/src/zope/wfmc/xpdl.py 2005-07-29 18:19:31 UTC (rev 37557)
@@ -267,8 +267,8 @@
return {'source': self.source}
def __call__(self, data):
- # XXX we *depend* on being able to use the data's dict.
- # This needs to be part of the contract.
+ # We *depend* on being able to use the data's dict.
+ # TODO This needs to be part of the contract.
try:
compiled = self._v_compiled
except AttributeError:
More information about the Zope3-Checkins
mailing list