[Zope3-checkins] Broken ZODB (was SVN: Zope3/trunk/src/zope/app/authentication/Eliminated all old-style classes)

[Jim Fulton]

Garrett Smith wrote:
> This change has broken presisted SessionCresentials. I'm not sure why,
> but the unpickler is calling SessionCredentials __init__.

This is probably because instances of new-style and old-style classes
get pickled differently.

> I'm not sure what the right course is here, but I think something should
> be done.

Technically, I don't agree.  3.1 is the first release with the pluggable
authentication utility, so backward compatbility isn't strictly necessary.

 > One of these perhaps:
> 
> - Revert to old style class
> - Write a conversion script
> - Provide a BBB signature of __init__ with default values for login and
> password

If this works, I'd say go for it.  But we should get rid of it soon.
Perhaps if there is another beta, we can put it in there, and take it
out for the final.

> Also, since SessionCredentials is stored as session data, should it not
> be Persistent?

Only if it is modified after creation, which I doubt.

Jim

-- 
Jim Fulton           mailto:jim at zope.com       Python Powered!
CTO                  (540) 361-1714            http://www.python.org
Zope Corporation     http://www.zope.com       http://www.zope.org