[Zope3-checkins] SVN: Zope3/trunk/src/zope/testbrowser/ Fix some bugs in mechanize.

Gary Poster gary at zope.com
Mon Oct 31 14:52:48 EST 2005


On Oct 28, 2005, at 12:20 PM, Stephan Richter wrote:

> Log message for revision 39691:
>   Fix some bugs in mechanize.

Hey.  These changes break the testbrowser goBack method (for which I  
guess there are insufficient tests), duplicate some changes already  
made to the mechanize that John J Lee maintains, likely break the  
mechanize tests (which are not included in the testbrowser package),  
and generally make the reintegration of John J. Lee's recent work  
more difficult.

I'm going to try to integrate John's new version now, and discard  
your changes.  John already believes he has fixed the memory leak.   
It looks like you may have other changes, but these will have to be  
readdressed later.

Moreover, after I have integrated the new versions, the imported code  
of the various testbrowser dependencies should be off-limits for  
changes.  If someone needs to make changes to one of the  
dependencies, they should work through John J. Lee, who is a  
responsive maintainer.  Minimally, changes to the dependency code  
should not be made without running its tests.  The layout of the  
tests make them difficult to include in Zope 3, but I'll think about  
adding them.

This is a bug fix: it may not be done today, but it should be fixed  
for Zope 3.2.

Gary


More information about the Zope3-Checkins mailing list