[Zope3-checkins] Re: SVN: Zope3/trunk/src/zope/formlib/form.py Small bugfix, correct import path

[dev at projekt01.ch]

Hi Philipp

> Roger Ineichen wrote:
> > Log message for revision 67264:
> >   Small bugfix, correct import path
> > 
> > Changed:
> >   U   Zope3/trunk/src/zope/formlib/form.py
> > 
> > -=-
> > Modified: Zope3/trunk/src/zope/formlib/form.py
> > ===================================================================
> > --- Zope3/trunk/src/zope/formlib/form.py	2006-04-21 
> 22:04:21 UTC (rev 67263)
> > +++ Zope3/trunk/src/zope/formlib/form.py	2006-04-21 
> 23:16:54 UTC (rev 67264)
> > @@ -753,7 +753,7 @@
> >                      
> zope.app.form.browser.interfaces.IWidgetInputErrorView)
> >                  title = getattr(error, 'widget_title', 
> None) # duck typing
> >                  if title:
> > -                    if isinstance(title, 
> zope.i18nmessageid.Message):
> > +                    if isinstance(title, zope.i18n.Message):
> >                          title = zope.i18n.translate(title, 
> context=self.request)
> >                      yield '%s: %s' % (title, view.snippet())
> >                  else:
> 
> You replaced a correct import path with an uncorrect one. 
> Please revert this.

Ok, right

The import *zope.i18nmessageid.Message* which was used wasn't 
included (import zope.i18nmessageid) in the header.

The zope.i18n.Message is also used at line 593 in:
if isinstance(label, (zope.i18n.Message, zope.i18n.MessageID)):

I fixed just the missing import which doesn't exist for 
zope.i18nmessageid. If we need to cleanup this we also have to 
change the MessageID used at line 593. right?

see line 593:
if isinstance(label, (zope.i18n.Message, zope.i18n.MessageID)):

How can I replace this and support BBB for the used MessageID?

Can you point me to the right direction?

Regards
Roger Ineichen


> Philipp
> 
> _______________________________________________
> Zope3-Checkins mailing list
> Zope3-Checkins at zope.org
> http://mail.zope.org/mailman/listinfo/zope3-checkins
>