[Zope3-dev] Re: zc.selenium test isolation

[Tres Seaver]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Christian Theune wrote:
> Am Mittwoch, den 10.01.2007, 11:04 -0500 schrieb Benji York:
>> Christian Theune wrote:
>>> I propose to add an "ultimate" pop at the beginning of each test, to
>>> ensure consistency/isolation at those points.
>> Where "ultimate pop" means to remove all stacked demostorages added by 
>> previous tests?  If so, sounds good.
>>
>> I do worry a little about that hiding mismatched push/pop operations in 
>> non-failing tests.  Perhaps the "ultimate pop" could generate a selenium 
>> error if there was anything there to pop.
> 
> I think that would defeat the purpose of having the other tests pass and
> not get spurious errors.

If pushing / popping demostorages is done by code in the tests
themselves, then failure to clean up afterwards is failture (like
failing to reset the component architecture).

> I think under normal conditions, the mismatched operations shouldn't be
> a problem, anyway, normal users of zc.selenium shouldn't have to worry
> about it. All of those operations are generated automatically anyway.

Then why do we need the "utlimate" pop, if not to catch a programmer error?


Tres.
- --
===================================================================
Tres Seaver          +1 540-429-0999          tseaver at palladion.com
Palladion Software   "Excellence by Design"    http://palladion.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.2 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFFpRJk+gerLs4ltQ4RAl6PAJ48i8iblJ4vuqi7SwezauKRJe8JkACgtud4
tqvDHPMr2Jyxnx82vuuwjHY=
=GAxS
-----END PGP SIGNATURE-----