[Zope3-Users] Re: formlib vs. cancel button

[Marius Gedminas]

On Thu, Feb 15, 2007 at 05:37:52PM +0100, Philipp von Weitershausen wrote:
> Martin Aspeli wrote:
> >Marius Gedminas wrote:
> >>On Thu, Feb 15, 2007 at 09:55:19AM +0000, Martin Aspeli wrote:
> >>>Dennis Schulz wrote:
> >>>>I dont know if it is the "proper" way,
> >>>>but when I return an empty string there is no validation error.
> >>>>
> >>>>This was also one of the strangest things I found out with formlib.....
> >>>I found that returning {} also works.
> >>
> >>The validator is supposed to return a list of errors.  Neither '' nor {}
> >>are lists.  () is a list.  I use
> >>
> >>    @form.action("Cancel", validator=lambda *a: ())
> >>    def cancel(self, action, data):
> >>        ...
> >>
> >>>But this is clearly a design weakness if there is no other way of 
> >>>doing it. Something like validator=NULL_VALIDATOR would be fine, or 
> >>>some kind of decorator.
> >>
> >>+1 for allowing
> >>
> >>    @form.action("Cancel", validator=form.no_validation)
> >
> >I added something similar to plone.app.form, but there really, really 
> >should be support for this use case in formlib in a non-hacky way.
> 
> We happily accept patches through collector entries. Actually, aren't 
> you a committer? :)

I'd be happy to implement and commit something, but I'd be happier if
someone else designed the API.  When I try to design APIs myself, I tend
to change my mind too often.  Now I want

    @form.action("Cancel", validator=None)

to mean "do no validation".  But perhaps that's not backwards-compatible
enough?

Marius Gedminas
-- 
The *REAL* Y2K is the year 2048.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://mail.zope.org/pipermail/zope3-users/attachments/20070215/f78e81c9/attachment.bin