-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Florent Guillaume wrote:
On 2 Dec 2005, at 11:09, Chris Withers wrote:
I was planning on rolling my changes out to 2.8, 2.9 and the trunk. Unless anyone strenuously objects, I still intend to do that. I cleaned up a lot of the code and made a few other changes that generally improve logging.
I strenuously object to you overwriting without consultation code I just checked in and that was approved by at least 3 people.
And I'm totally -1 on any logging at level INFO or above about retriable conflict errors.
Likewise -1. A successfully retried conflict should not clutter up the log. In another message, Chris wrote:
Not so. If I'm getting 1,000 resolved conflict errors a day, that can be a big performance hit, and there are those of us who have hard performance targets to meet ;-) Turning on debug logging is, in itself, a performance hit, so I don't want to have to do that on a production service where I want to observe the number of conflict errors occurring over a long period of time, like, say, a month.
You need to plan to set up and *additional* logging handler for this, which logs *only* conflict errors at *whatever* level, rather than requiring everybody else to live with output they don't need or want to see. I figured out how to do this once, long ago, to surface some obscure BLATHER-level notification; given your familiarity with the logging module, it should be a snap for you. ;) Tres. - -- =================================================================== Tres Seaver +1 202-558-7113 tseaver@palladion.com Palladion Software "Excellence by Design" http://palladion.com -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.1 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org iD8DBQFDkF3j+gerLs4ltQ4RAsLtAJ90STWiXGtO77wMZJ7c0Y7R8a22yQCeIW9/ 7Qe7tteducXydAGO54RpkJg= =u8L+ -----END PGP SIGNATURE-----