-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 04/18/2011 12:01 PM, Laurence Rowe wrote:
When using response.appendHeader, Zope appends the new value following an ",\r\n\t" which splits the header over multiple lines. While this behaviour is standards compliant, it causes problems for both Varnish [1] and Nginx [2] which may then mangle the header value.
In fact the HTTP 1.0 spec notes that splitting over multiple lines in not recommended [3], though the HTTP 1.1 spec does not mention this explicitly, though it does say [4]: "Applications ought to follow "common form", where one is known or indicated, when generating HTTP constructs, since there might exist some implementations that fail to accept anything"
Are there any objections to me applying the attached patch to Zope 2.13 and trunk?
+0. We likely need to test that your patch doesn't break stuff on other maybe-not-compliant servers (older Apache, IIS). Tres. - -- =================================================================== Tres Seaver +1 540-429-0999 tseaver@palladion.com Palladion Software "Excellence by Design" http://palladion.com -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk2shMUACgkQ+gerLs4ltQ4oKgCg0/BXLTh3VvpBGeNgc+WFKx9V UdEAnRp1lxbXDKFbrJ8nBwgWaRJ/B0y1 =xjg8 -----END PGP SIGNATURE-----