On 8/2/09 5:23 PM, Hanno Schlichting wrote:
On Sun, Aug 2, 2009 at 10:41 PM, Chris McDonough<chrism@plope.com> wrote:
That said, why does Zope 2.1.2 use the zope.index textindex? The Zope 2 implementation is still very superior.
The current policy for the test runs is to test both all direct dependencies and all transitive dependencies including all test dependencies on all levels. We have spent quite some time reducing the "real" dependencies already, but the test dependencies are still in a somewhat worse state.
So in this case zope.app.zptpage has a code dependency on zope.index. And zope.app.zptpage is a test dependency of a number of packages, including zope.traversing, zope.app.exception and zope.app.publication.
OK. There's no way any release of Zope 2 should depend on zope.index, at least until its index implementations are as good as the ones in Zope 2 itself. I don't know if in the short term (for a release) that means that the Zope 2 test regime needs to change, or if the dependencies need to be fixed, or what. In the medium term, we should fix the dependencies obviously. Another immediate thing to do would just be to pin the zope.index version to 3.5.1, given that it doesn't matter one way or another whether these tests pass for purposes of a Zope 2 release.
I think it might be time to remove the test extras again for "reusable zope.*" packages and declare them as real dependencies. This would allow us to actually see them more easily and get truly embarrassed - a good way of spurring motivation to fix the mess ;-)
Oh good, I might win that beer from Martijn after all. ;-) - C