-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 06/11/2011 11:36 AM, Hanno Schlichting wrote:
On Sun, Jun 5, 2011 at 8:24 PM, Hanno Schlichting <hanno@hannosch.eu> wrote:
$ bin/alltests -s Acquisition -t test_mixed_explicit_and_explicit Running zope.testrunner.layer.UnitTests tests: Set up zope.testrunner.layer.UnitTests in 0.000 seconds. Segmentation fault
I haven't yet tried to debug the problem itself.
I took the time to investigate this. It came down to the same issue noted in https://bugs.launchpad.net/bugs/675064. Some code treated a C int as a pointer. Apparently on most platforms sizeof(int) == sizeof(pointer), but there's some where that's not the case.
In this particular case it was a simple mistake of using the wrong variable:
PyObject *expl=0; int explicit=1;
UNLESS (PyArg_ParseTupleAndKeywords( args, kw, "O|OOOOi", acquire_args+1, &name, &filter, &extra, &explicit, &defalt, &containment )) return NULL;
if (expl) explicit=PyObject_IsTrue(expl);
The fix was to pass &expl instead of &explicit into PyArg_ParseTupleAndKeywords. Almost the same code existed in Wrapper_acquire_method and module_aq_acquire and only Wrapper_acquire_method got it wrong.
I released a new Acquisition version and put it into Zope 2.x. Hopefully the buildbots will finally get green again.
Excellent! Thanks very much for tracking the beast to its lair and aq_wrenching of its arm (now we just need to watch out for its mother ;) Tres. - -- =================================================================== Tres Seaver +1 540-429-0999 tseaver@palladion.com Palladion Software "Excellence by Design" http://palladion.com -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk3zjhIACgkQ+gerLs4ltQ5KSgCgqGXWqmpqbPJiolsWjLY9nGmM xyUAoIZBc5acuHPzpiY/WV9wqtOYX0l1 =wIQ8 -----END PGP SIGNATURE-----