Hello Yuppie! I was initially somewhat uncomfortable with the fact that you have changed the ordering API completely. Where has 'move_object_up' gone, and where is 'manage_move_object_up'? Is there an upgrade path for code using the classic API of OrderedFolder or the OrderedFolderSupportPatch? Well, at least the names do not collide and both APIs will be able to coexist. ;-) I am however less convinced about the changes you made to the Folder class on Friday: <http://cvs.zope.org/Zope/lib/python/OFS/Folder.py.diff?r1=1.101.66.1&r2=1. 101.66.2&only_with_tag=yuppie-ordersupport-branch> Adding an __init__() method is quite a significant change! Furthermore, the way you did it alters the behaviour of the Folder class which is not acceptable. If you absolutely want to add a Folder constructor, please do it in a b/w compatible way. I suggest you consider the implementation proposed here: <http://mail.zope.org/pipermail/zope-dev/2002-July/016913.html> Oh, and the up/down GIFs are hideous. ;-) IMO, Stefan --On Montag, 05. Mai 2003 13:35 +0200 Yuppie <schubbe@web.de> wrote:
Implementing the OrderedObjectManager proposal, we fleshed it out and modified it a bit. I made an initial checkin on a branch which reflects our current thinking. So this is your chance to discuss the changes before we merge it into the trunk.
The code: yuppie-ordersupport-branch (Creating the branch went wrong a bit. Please just checkout lib/python/AccessControl, lib/python/OFS and lib/python/Products/OFSP.)
The original proposal: <http://dev.zope.org/Wikis/DevSite/Proposals/OrderedObjectManager>
-- The time has come to start talking about whether the emperor is as well dressed as we are supposed to think he is. /Pete McBreen/