Hi, On 19 August 2010 16:46, Hanno Schlichting <hanno@hannosch.eu> wrote:
Hi.
On Thu, Aug 19, 2010 at 6:15 AM, David Glick <davidglick@groundwire.org> wrote:
As an alternative to requiring calling setDefaultRoles/addPermission at import time, I suggest that we add an optional roles attribute to the <permission> directive. This would then be used when the directive is executed, instead of the current hard-coded Manager setting. Examples:
<!-- a new permission with 2 default roles --> <permission id="my.NewPermission" title="My new permission" roles="Manager SiteAdmin"/> <!-- a new permission with Manager as the sole, implicit role (backwards-compatible) --> <permission id="my.OtherPermission" title="My other permission"/>
Can roles currently contain whitespace? Like "Awesome People"?
Yes, they can.
If so, we should go for nested nodes:
<permission id="my.NewPermission" title="My new permission"> <role>Manager</role> <role>SiteAdmin</role> <role>Awesome People</role> </permission>
I think this matches the style of some of the GenericSetup handlers which deal with permissions.
+1 Martin