I forward-ported these to the 2.7 branch & the head. Any testing you can do to make sure I didn't break anything would be appreciated. Brian Lloyd brian@zope.com V.P. Engineering 540.361.1716 Zope Corporation http://www.zope.com
-----Original Message----- From: zope-dev-bounces@zope.org [mailto:zope-dev-bounces@zope.org]On Behalf Of Hajime Nakagami Sent: Wednesday, January 14, 2004 1:29 PM To: zope-dev@zope.org Subject: Re: [Zope-dev] 2.7 management_page_charset cannot be callable anymore
+1
I think the problem is same as reported by Kazuya Fukamachi http://mail.zope.org/pipermail/zope-dev/2003-December/021315.html and me. http://mail.zope.org/pipermail/zope-dev/2003-December/021338.html
At least this is important problem in Japanese (maybe Korea and Chinese) developpers.
Hi there,
Some changes in Zope 2.7 break the possibility to make management_page_charset a callable (for instance a method).
This breaks Formulator, as it uses this facility. This works just fine in Zope 2.6, but breaks in Zope 2.7.
The silly thing is that Formulator 2.6.0 breaks in Zope 2.7 exactly because it actually is the release that tries to do unicode *right* (while still retaining backwards compatibility with older installations and offering a non-unicode mode), and then Zope 2.7 makes it impossible.
I heard a report that a similar problem may be occuring with ZWiki..
The problem is in lib/python/App/dtml/manage_page_header.dtml:
<dtml-unless management_page_charset> <dtml-call "REQUEST.set('management_page_charset','iso-8859-1')"> </dtml-unless> <meta http-equiv="content-type" content="text/html;charset=&dtml-management_page_charset;"> <dtml-call "RESPONSE.setHeader('content-type','text/html;charset='+management _page_charset)">
If I remember my DTML well, &dtml-management_page_charset; should still call the method if it's a callable, so that would be all right.
The next line however breaks, as it's going to treat my method as an attribute.
I think backwards compatibility got broken unintentionally here.. Could this be restored? Using a ComputedAttribute for this would be rather involved and it's possible other products are broken as well as a result.
Regards,
Martijn
_______________________________________________ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )