On Tue, Dec 2, 2008 at 6:48 AM, Dan Korostelev <nadako@gmail.com> wrote:
2008/12/2 Marius Gedminas <marius@gedmin.as>:
On Tue, Dec 02, 2008 at 02:04:39AM +0300, Dan Korostelev wrote:
I just removed zope.testing from the zope.index dependency and replaced zope.testing.doctest imports with plain python doctest and it seems to work with python 2.4 and 2.5 here. Now, it only depends on ZODB3 and zope.interface, which is nice :) Is there any objections on this?
Yes.
Using 'import doctest' rather than 'from zope.testing import doctest' was a pretty reliable way to break test.py --coverage, at least on Python 2.4.
Oh, thanks for the hint. I'll fix that now. :) There's no need to use try/except though, it's nicer just to create an extras_require for tests, I think.
The status quo is to forgo creating extras unless there is a compelling reason to have one. Creating a test extra just to remove a dependency on zope.testing -- which only depends on zope.interface -- is not compelling. -- Benji York Senior Software Engineer Zope Corporation