On Fri, Mar 12, 2010 at 11:09 AM, Marius Gedminas <marius@gedmin.as> wrote:
On Thu, Mar 11, 2010 at 08:52:11PM +0000, Jonathan Lange wrote:
=== modified file 'src/zope/testing/testrunner/testrunner-leaks.txt' --- src/zope/testing/testrunner/testrunner-leaks.txt 2008-05-05 18:50:48 +0000 +++ src/zope/testing/testrunner/testrunner-leaks.txt 2010-02-20 22:23:32 +0000 @@ -16,7 +16,7 @@ >>> from zope.testing import testrunner
>>> sys.argv = 'test --layer Layer11$ --layer Layer12$ -N4 -r'.split() - >>> _ = testrunner.run(defaults) + >>> _ = testrunner.run_internal(defaults)
I'm curious about this change.
Sidnei explained it correctly. This particular file is only tested if you're running a Python with --with-pydebug set, so it's easy to miss when you make a change.
Ah! That explains why it wasn't fixed on trunk.
(This bit should probably be committed separately. And zope.testing could use a bit more continuous integration with various Python versions/build flags...)
I committed this change as a separate revision, and merged the rest of the patch after that. I guess I should make a 3.9.0 release now. Any objections? -- Sidnei