On Sun, 2002-02-03 at 21:58, Richard Jones wrote:
On Fri, 1 Feb 2002 21:53, seb bacon wrote:
I wrote:
I've just announced our Call Profiler product on zope.org and the zope announce list (waiting for people in different timezones to authorise them :) ( http://www.zope.org/Members/richard/CallProfiler/ for the impatient)
This is absolutely excellent, well done and thanks :) I added various FSObjects to the profiled modules list and have been looking at my CMF systems - it's really instructive.
Please send me the config entries for them. Also, if anyone has used ZPT with it, let me know if my guess of the config for them is correct :)
in profileable_modules: 'FSPythonScript': Profileable('Products.CMFCore.FSPythonScript', 'FSPythonScript', '__call__'), 'FSDTMLMethod': Profileable('Products.CMFCore.FSDTMLMethod', 'FSDTMLMethod', '__call__'), 'FSPageTemplate': Profileable('Products.CMFCore.FSPageTemplate', 'FSPageTemplate', '__call__'),
You could do this check only if zope is being run in debug mode; then there would be zero perormance hit in production sites.
No, there's still the performance check for "am I in debug mode?" which is equivalent to "am I in profiling mode?". Sure, it's small, but it's there.
- the trace for a complete template could be slightly clearer. The colour coding for the start and end of a module could have a clear legend, for example.
I'll put a legend in. Is the colour coding what you meant by "clearer" or is there something else?
Yes, that's what I meant. Actually, another thing just occurred to me: the meaning of the "..." ellipsis is not clear - I think you need a different symbol to emphasise the hierarchy (perhaps a vertical bar?) Cheers, seb