17 Sep
2013
17 Sep
'13
11:03 a.m.
On 9/17/13 12:04 PM, Jan-Wijbrand Kolman wrote: snip
2) fork the repository, make a branch in the fork, do my work, push the changes to my fork, and issue a pull request.
The latter is what I did, without explicitly asking for feedback. Luckily someone did give me feedback (thanks!) :-)
Now that I mended the pull request, should I merge the pull request myself? Or is the current etiquette that someone else should merge the pull request?
This is what I did just now. Kind regards, jw