On 25 February 2011 11:14, Godefroid Chapelle <gotcha@bubblenet.be> wrote:
Le 25/02/11 12:03, Hanno Schlichting a écrit :
I find a few string exceptions leftover in Zope 2.13 code.
What practice has been followed until now regarding fixing those exceptions ?
Just upgrade them to new-style exception classes. Since string exceptions cannot possibly work anymore, we cannot make things worse by fixing them.
Hanno
What about deciding to kill that code ?
I guess it is a bit early because not enough people did migrate to 2.12 or later.
These statements now raise a TypeError instead of a string exceotion, which in most cases should be functionally equivalent. There's no guarantee that the code is dead.
Where should those fixes happen ?
2.13 branch and trunk I suppose
This seems sensible. Laurence