On Sat, 2004-01-17 at 16:58, Jeff Kowalczyk wrote:
(sidebar, the zopectl error is: $ /var/zope/bin/zopectl start Traceback (most recent call last): File "/opt/Zope-2.8/lib/python/Zope/Startup/zopectl.py", line 207, in ? main() File "/opt/Zope-2.8/lib/python/Zope/Startup/zopectl.py", line 190, in main c.onecmd(" ".join(options.args)) File "/usr/lib/python2.3/cmd.py", line 210, in onecmd return func(arg) File "/opt/Zope-2.8/lib/python/Zope/Startup/zopectl.py", line 134, in do_start ZDCmd.do_start(self, arg) File "/opt/Zope-2.8/lib/python/zdaemon/zdctl.py", line 205, in do_start args += self._get_override("-m", "umask") File "/opt/Zope-2.8/lib/python/Zope/Startup/zopectl.py", line 116, in _get_override value = getattr(self.options, name) AttributeError: ZopeCtlOptions instance has no attribute 'umask'
I committed a patch with the umask option a few days ago. I thought it only affected zdaemon and the tests all looked clean afterwards. I'm not sure how zopectl.py ends up being affected or why there aren't any tests of it. The various scripts to start and stop programs are usually hard to test, but they're usually the source of a lot of bugs, too. Jeremy