According to CHANGES.txt, you're fixing a bug. Where's the test that exercises that the bug fix code? (Yes, I'm going to get anal about this.) To anybody, the fix will look a bit dubious. At least I personally am wondering how simply changing the datatype in the ZConfig schema will work... A comment explaining *why* this fixes the problem would clear up any doubts. Such a commonent could very well have been placed in the above mentioned test that's missing. Please provide it. Wichert Akkerman wrote:
Log message for revision 80452: Merge r80451 from trunk
Changed: U Zope/branches/2.10/doc/CHANGES.txt U Zope/branches/2.10/lib/python/Zope2/Startup/zopeschema.xml
-=- Modified: Zope/branches/2.10/doc/CHANGES.txt =================================================================== --- Zope/branches/2.10/doc/CHANGES.txt 2007-10-01 19:48:13 UTC (rev 80451) +++ Zope/branches/2.10/doc/CHANGES.txt 2007-10-01 20:05:49 UTC (rev 80452) @@ -8,6 +8,9 @@
Bugs fixed
+ - Launchpad #147201: treat container-class in zope.conf as a string, + making it possible to use types from extra products directories. + - Collector #2358: backported fix making 'Products' package a real "namespace package" from the trunk.
Modified: Zope/branches/2.10/lib/python/Zope2/Startup/zopeschema.xml =================================================================== --- Zope/branches/2.10/lib/python/Zope2/Startup/zopeschema.xml 2007-10-01 19:48:13 UTC (rev 80451) +++ Zope/branches/2.10/lib/python/Zope2/Startup/zopeschema.xml 2007-10-01 20:05:49 UTC (rev 80452) @@ -242,7 +242,7 @@ </description> </key>
- <key name="container-class" datatype=".python_dotted_path"> + <key name="container-class" datatype="string"> <description> Change the contiainer class a (mounted) database uses on a per-database basis to support a different container than a plain
-- http://worldcookery.com -- Professional Zope documentation and training